Skip to content

Conversation

Thodd
Copy link
Contributor

@Thodd Thodd commented Apr 11, 2019

Resolves #166

NPM dependencies which cannot be configured (via yaml or shim) are
considered invalid and should not be part of the final project tree.

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 83.31% when pulling f93989c on fix-preprocessor-dep-handling into 56b55f2 on master.

@coveralls
Copy link

coveralls commented Apr 11, 2019

Coverage Status

Coverage increased (+1.0%) to 83.31% when pulling c25ae03 on fix-preprocessor-dep-handling into e3f804d on master.

@SAP SAP deleted a comment from CLAassistant Apr 11, 2019
@Thodd Thodd force-pushed the fix-preprocessor-dep-handling branch from f93989c to 5757d4e Compare April 11, 2019 08:50
@Thodd Thodd requested a review from RandomByte April 11, 2019 08:52
@RandomByte
Copy link
Member

The dependencies issue label is meant for npm dependency updates/changes to this project. Such as the dependabot pull requests.

RandomByte
RandomByte previously approved these changes Apr 11, 2019
@RandomByte
Copy link
Member

Nicenstein 🎉

@RandomByte
Copy link
Member

Minor remark: You may rename the commit message to

[FIX] ProjectPreprocessor: Fixes dependency processing

Also see https://github.com/SAP/ui5-tooling/blob/master/docs/Guidelines.md#commit-summary:

It shall be written in imperative present tense (as recommended by Git)
Examples: Instead of "Adding tests for" or "I added tests for" use "Add tests for" or "Add feature xy".

NPM dependencies which cannot be configured (via yaml or shim) are
considered invalid and should not be part of the final project tree.
@Thodd Thodd force-pushed the fix-preprocessor-dep-handling branch from 5757d4e to c25ae03 Compare April 12, 2019 06:44
@RandomByte RandomByte changed the title [FIX] ProjectPreprocessor: Fixes dependency processing [FIX] ProjectPreprocessor: Fix dependency processing Apr 12, 2019
@Thodd Thodd merged commit 0671a8b into master Apr 12, 2019
@Thodd Thodd deleted the fix-preprocessor-dep-handling branch April 12, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot read property 'name' of undefined

4 participants