Cannot read property 'name' of undefined

[sven-petersen]

Expected Behavior

ui5 build -a exits with exit code 0 (or errors with a useful error message).

Current Behavior

ui5 build -a fails with the error below (folder path shortened).

info builder:builder Building project openui5-sample-app including dependencies...
TypeError: Cannot read property 'name' of undefined
    at projectCount (/Users/.../openui5-sample-app/node_modules/@ui5/builder/lib/builder/builder.js:186:45)
    at project.dependencies.reduce (/Users/.../openui5-sample-app/node_modules/@ui5/builder/lib/builder/builder.js:183:13)
    at Array.reduce (<anonymous>)
    at projectCount (/Users/.../openui5-sample-app/node_modules/@ui5/builder/lib/builder/builder.js:182:34)
    at project.dependencies.reduce (/Users/.../openui5-sample-app/node_modules/@ui5/builder/lib/builder/builder.js:183:13)
    at Array.reduce (<anonymous>)
    at projectCount (/Users/.../openui5-sample-app/node_modules/@ui5/builder/lib/builder/builder.js:182:34)
    at project.dependencies.reduce (/Users/.../openui5-sample-app/node_modules/@ui5/builder/lib/builder/builder.js:183:13)
    at Array.reduce (<anonymous>)
    at projectCount (/Users/.../openui5-sample-app/node_modules/@ui5/builder/lib/builder/builder.js:182:34)

Steps to reproduce the issue

1. execute git clone git@github.com:SAP/openui5-sample-app.git && cd openui5-sample-app
2. execute npm i --save @babel/polyfill mobx serve && npm i --save-dev @babel/core @babel/preset-env && npm uninstall karma karma-chrome-launcher karma-openui5 karma-qunit rimraf start-server-and-test karma-coverage qunitjs && npm i
3. replace ui5.yaml's content with https://gist.githubusercontent.com/aktivalux/5e979bd330bb2006acb06b239411296d/raw/509886c18ccc0d0bf5c65b999af392e28aa69351/ui5.yaml
4. execute ui5 build --all

Context

• UI5 Module Version (output of ui5 --version when using the CLI): 1.2.4
• Node.js Version: v8.11.4 (also tested with v10.15.3)
• npm Version: 5.6.0 (also tested with 6.4.1)
• OS/Platform: macOS Mojave 10.14.4
• Browser (if relevant): N/A

Additional observations

The error seems to occure in the specific combination of the installed packages and the ui5.yaml. If you for example just uninstall one of mobx, @babel/polyfill (both referenced in ui5.yaml as shim) or cross-var (not defined as shim; just required in the npm scripts) the build starts to work again.

Also it is only builds which also work with the dependencies (such as ui5 build -a or ui5 build self-contained) have issues.

Affected components (if known)

• ui5-builder
• ui5-server
• ui5-cli
• ui5-fs
• ui5-project
• ui5-logger

Log Output / Stack Trace

(see above / can be generated with ui5 build -a --verbose)

[RandomByte]

This seems to be rather related to UI5 Project. Therefore transferring this issue there.

The output of ui5 tree --full --json should not contain unconfigured projects. Yet the dependencies of mobx are included without any configuration.

Preprocessed dependency tree:

{
    "id": "openui5-sample-app",
    "version": "0.2.0",
    "path": "openui5-sample-app",
    "dependencies": [
        {
            "id": "@babel/polyfill",
            "version": "7.4.3",
            "path": "openui5-sample-app/node_modules/@babel/polyfill",
            "dependencies": [],
            "_level": 1,
            "specVersion": "1.0",
            "type": "module",
            "metadata": {
                "name": "@babel/polyfill"
            },
            "resources": {
                "configuration": {
                    "paths": {
                        "/resources/thirdparty/babel/polyfill/": "./dist"
                    }
                },
                "pathMappings": {
                    "/resources/thirdparty/babel/polyfill/": "./dist"
                }
            },
            "kind": "project"
        },
        // [...]
        {
            "id": "mobx",
            "version": "5.9.4",
            "path": "openui5-sample-app/node_modules/mobx",
            "dependencies": [
                {
                    "id": "chalk",
                    "version": "2.4.1",
                    "path": "openui5-sample-app/node_modules/serve/node_modules/chalk",
                    "dependencies": [
                        {
                            "id": "ansi-styles",
                            "version": "3.2.1",
                            "path": "openui5-sample-app/node_modules/ansi-styles",
                            "dependencies": [
                                {
                                    "id": "color-convert",
                                    "version": "1.9.3",
                                    "path": "openui5-sample-app/node_modules/color-convert",
                                    "dependencies": [
                                        {
                                            "id": "color-name",
                                            "version": "1.1.3",
                                            "path": "openui5-sample-app/node_modules/color-name",
                                            "dependencies": []
                                        },
                                        {
                                            "id": "chalk",
                                            "version": "2.4.1",
                                            "path": "openui5-sample-app/node_modules/serve/node_modules/chalk",
                                            "dependencies": [],
                                            "deduped": true
                                        }
                                    ]
                                }
                            ]
                        },
                        {
                            "id": "escape-string-regexp",
                            "version": "1.0.5",
                            "path": "openui5-sample-app/node_modules/escape-string-regexp",
                            "dependencies": []
                        },
                        {
                            "id": "supports-color",
                            "version": "5.5.0",
                            "path": "openui5-sample-app/node_modules/serve/node_modules/supports-color",
                            "dependencies": [
                                {
                                    "id": "has-flag",
                                    "version": "3.0.0",
                                    "path": "openui5-sample-app/node_modules/has-flag",
                                    "dependencies": []
                                }
                            ]
                        }
                    ]
                }
            ],
            "_level": 1,
            "specVersion": "1.0",
            "type": "module",
            "metadata": {
                "name": "mobx"
            },
            "resources": {
                "configuration": {
                    "paths": {
                        "/resources/thirdparty/mobx/": "./lib/"
                    }
                },
                "pathMappings": {
                    "/resources/thirdparty/mobx/": "./lib/"
                }
            },
            "kind": "project"
        }
    ],
    "_level": 0,
    "specVersion": "1.0",
    "metadata": {
        "name": "openui5-sample-app",
        "namespace": "sap/ui/demo/todo"
    },
    "type": "application",
    "kind": "project",
    "resources": {
        "configuration": {
            "paths": {
                "webapp": "webapp"
            }
        },
        "pathMappings": {
            "/": "webapp"
        }
    }
}

Expected would be that mobx has no dependencies in this tree.