Skip to content

Conversation

@mkska
Copy link
Contributor

@mkska mkska commented May 3, 2024

Pull Request Checklist

Description

https://remix.run example using ui5-webcomponents-react.
The hydration problems are managed through remix-island package.
Has the same look-and-feel as the nextjs-app example.
Closes #5050.

@cla-assistant
Copy link

cla-assistant bot commented May 3, 2024

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented May 3, 2024

Pull Request Test Coverage Report for Build 9203468206

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.49%

Totals Coverage Status
Change from base Build 9203002424: 0.0%
Covered Lines: 5420
Relevant Lines: 6125

💛 - Coveralls

Copy link
Contributor

@MarcusNotheis MarcusNotheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @mkska! 🎉
I've added some minor adjustments to the readme to be better aligned with our other examples, and added the link to your example in our storybook.

@MarcusNotheis MarcusNotheis enabled auto-merge (squash) May 23, 2024 06:39
@MarcusNotheis MarcusNotheis disabled auto-merge May 23, 2024 06:39
@MarcusNotheis MarcusNotheis enabled auto-merge (squash) May 23, 2024 06:40
@MarcusNotheis MarcusNotheis changed the title feat(remix-ts example): routing, theming, data fetching example docs(examples): add Remix example with routing, theming, and data fetching May 23, 2024
@MarcusNotheis MarcusNotheis merged commit 1d3decd into UI5:main May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remix starter

3 participants