Split texture's resize function into sRGB and non-sRGB #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisThrasher
approved these changes
Aug 31, 2025
|
Hmm, can't seem to find the approval button on GitHub mobile. This is my approval :) |
1 similar comment
|
Hmm, can't seem to find the approval button on GitHub mobile. This is my approval :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #177 we've implemented
sfTexture_resize, but the function takes aboolfor switching between RGB and non-RGB, which is counter to thesfTexture_createXmethods that each have their own sRGB versions.There are two ways forward:
createXandcreateSrgbXmethodsresizemethodI believe the reason for the separate functions are two fold:
This PR chooses the method split, so one doesn't need to always provide the boolean.