-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Trying to load a non-existing font file crashes an Android app #1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you try to unify the coding style regarding the |
Could you squash the commits? |
@1aam2am1 Could you squash the commits? |
I have no idea what you mean. I don't know so well github and English. |
Squashing means merging the commits to a single one. You can do that with git's interactive rebase ( If you want, we can also do it for you (signed-off-by). |
Anyone willing to do it with signed-off-by? Maybe @MarioLiebisch? |
Bump |
@MarioLiebisch Beside the extra braces, do you think it's mergeable? |
Braces are fixed in the updated commit, It could just need a better message. Maybe just cherry-pick it? |
Any suggestions for the better message? |
In my local copy before noticing the quotes being fixed already:
|
This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns. |
Merged in 36bb3c4 |
Trying to load a non-existing font file crashes an Android app #1056