New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to load a non-existing font file crashes an Android app #1058

Closed
wants to merge 1 commit into
base: master
from

Conversation

5 participants
@1aam2am1
Contributor

1aam2am1 commented Feb 8, 2016

Trying to load a non-existing font file crashes an Android app #1056

@1aam2am1 1aam2am1 closed this Feb 8, 2016

@Bromeon Bromeon added the not an issue label Feb 8, 2016

@1aam2am1 1aam2am1 changed the title from Issue #1056 to Trying to load a non-existing font file crashes an Android app Feb 18, 2016

@1aam2am1 1aam2am1 reopened this Feb 18, 2016

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Feb 18, 2016

Member

Could you try to unify the coding style regarding the if() brackets?

Member

MarioLiebisch commented Feb 18, 2016

Could you try to unify the coding style regarding the if() brackets?

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Mar 8, 2016

Member

Could you squash the commits?

Member

eXpl0it3r commented Mar 8, 2016

Could you squash the commits?

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Mar 29, 2016

Member

@1aam2am1 Could you squash the commits?

Member

eXpl0it3r commented Mar 29, 2016

@1aam2am1 Could you squash the commits?

@1aam2am1

This comment has been minimized.

Show comment
Hide comment
@1aam2am1

1aam2am1 Mar 30, 2016

Contributor

I have no idea what you mean. I don't know so well github and English.

Contributor

1aam2am1 commented Mar 30, 2016

I have no idea what you mean. I don't know so well github and English.

@Bromeon

This comment has been minimized.

Show comment
Hide comment
@Bromeon

Bromeon Apr 3, 2016

Member

Squashing means merging the commits to a single one. You can do that with git's interactive rebase (git rebase -i).

If you want, we can also do it for you (signed-off-by).

Member

Bromeon commented Apr 3, 2016

Squashing means merging the commits to a single one. You can do that with git's interactive rebase (git rebase -i).

If you want, we can also do it for you (signed-off-by).

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r May 18, 2016

Member

Anyone willing to do it with signed-off-by? Maybe @MarioLiebisch?

Member

eXpl0it3r commented May 18, 2016

Anyone willing to do it with signed-off-by? Maybe @MarioLiebisch?

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Jun 22, 2016

Member

Bump

Member

eXpl0it3r commented Jun 22, 2016

Bump

Issue #1056
Update ResourceStream.cpp
@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Jul 6, 2016

Member

@MarioLiebisch Beside the extra braces, do you think it's mergeable?

Member

mantognini commented Jul 6, 2016

@MarioLiebisch Beside the extra braces, do you think it's mergeable?

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Jul 17, 2016

Member

Braces are fixed in the updated commit, It could just need a better message. Maybe just cherry-pick it?

Member

MarioLiebisch commented Jul 17, 2016

Braces are fixed in the updated commit, It could just need a better message. Maybe just cherry-pick it?

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Jul 17, 2016

Member

Any suggestions for the better message?

Member

eXpl0it3r commented Jul 17, 2016

Any suggestions for the better message?

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Jul 17, 2016

Member

In my local copy before noticing the quotes being fixed already:

Added pointer checks to Android's resource stream

This fixes issue #1056.

Member

MarioLiebisch commented Jul 17, 2016

In my local copy before noticing the quotes being fixed already:

Added pointer checks to Android's resource stream

This fixes issue #1056.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Jul 18, 2016

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Jul 18, 2016

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Jul 21, 2016

Member

Merged in 36bb3c4

Member

eXpl0it3r commented Jul 21, 2016

Merged in 36bb3c4

@eXpl0it3r eXpl0it3r closed this Jul 21, 2016

@1aam2am1 1aam2am1 deleted the 1aam2am1:patch-1 branch Nov 15, 2016

@eXpl0it3r eXpl0it3r added this to Done in Android Backlog Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment