Added joystick example. #1363

binary1248 · 2018-02-03T12:11:43Z

Originally used when testing #1326 but can be used with the existing code as well.

MarioLiebisch · 2018-02-04T13:33:49Z

examples/joystick/Joystick.cpp

+        window.clear();
+
+        // Draw the label-value sf::Text objects
+        for (Texts::const_iterator i = texts.begin(); i != texts.end(); ++i)


If there's no controller connected it will still spit out basically placeholder text for the first controller. Maybe there should be some instruction like "No controllers could be found. Connect a gamepad or joystick to test it."?

The text that is always output isn't placeholder text, they are simply the labels of the joystick items. When a joystick is connected, values will be displayed for the last joystick whose state was modified. When no joysticks are connected, no values are displayed.

Yeah, but (at least to me) from a first look it's still not clear whether the program is stuck or just couldn't find any joystick. So maybe just rather than setting ID to nothing, set it to <Not connected>, if there's no controller? Similar not existing buttons/axes should possibly output "n/a" rather than nothing.

MarioLiebisch · 2018-02-04T13:37:03Z

I'm not really sure about the whole text output only. I'd prefer something visual, even if it just consists of simple shapes. Maybe something like this (potentially with more text):

binary1248 · 2018-02-05T00:42:34Z

The point of this example is to demonstrate usage of the joystick API. The predecessor to this code would output purely to the console, however it would become unreadable when outputting all the possible values of a joystick's state hence the sfml-graphics output. The current text rendering already takes up almost half of the code. Making it any more sophisticated such as in the picture you posted will shift the focus of the code away from the joystick API to the drawable API which shouldn't be the case in a joystick example. This should stay as an example and not become some kind of debug tool.

MarioLiebisch · 2018-02-05T08:24:23Z

Yeah, probably true,

MarioLiebisch · 2018-02-05T08:28:05Z

examples/joystick/Joystick.cpp

+        text.second.setPosition(80.f, 5.f + ((sf::Joystick::AxisCount + i + 2) * font.getLineSpacing(14)));
+    }
+
+    for (Texts::iterator i = texts.begin(); i != texts.end(); ++i)


Also, maybe just me, but I prefer to reserve i, j, etc. for numerical indices, while using a, b, etc. for iterators (even though [i]terator makes sense).

My personal convention, and thus most likely what's used in SFML, is to use it for iterators.

MarioLiebisch · 2018-02-05T08:30:31Z

examples/joystick/Joystick.cpp

+
+namespace
+{
+    typedef std::map<std::string, std::pair<sf::Text, sf::Text> > Texts;


While convenient and using existing classes, I'd really just define a small struct for the values here, even if it's just to identify the components as label and value or something like that. It's about readability and the chained expressions with first or second just feel a bit odd.

Agreed. std::pair is never a good choice.

MarioLiebisch · 2018-02-05T08:32:44Z

examples/joystick/Joystick.cpp

+    std::ostringstream sstr;
+
+    // Axes labels in as C strings
+    const char* axislabels[] = {"X", "Y", "Z", "R", "U", "V", "PovX", "PovY"};


While it's unlikely the enum values for the axes might change, I'm not really a fan of just assuming a constant/fixed order here.

In core SFML code I would agree, but this is just an example, so it's a good thing if we keep this kind of boilerplate code as short as possible.

MarioLiebisch · 2018-02-05T08:34:26Z

As an added feature, maybe allow the user to increase/decrease the movement threshold with some keys, like Page Up/Down, visualizing what it does?

eXpl0it3r · 2018-03-23T12:42:22Z

There are still some open suggestions, are you going to change things @binary1248? I mean it's just an example, doesn't have to be the best thing ever.

binary1248 · 2018-03-23T14:47:41Z

I still intend to work on this... yes.

binary1248 · 2018-03-24T16:06:33Z

@MarioLiebisch, @LaurentGomila, @eXpl0it3r: All the mentioned issues should be resolved in the current version.

eXpl0it3r · 2018-03-26T21:45:54Z

I don't own a joystick, can someone test this?

danieljpetersen · 2018-03-28T08:34:21Z

I just tried this out on Linux Mint 18.3

The Steam Controller identified as a 360 controller. It doesn't seem like this is working correctly here. Only three buttons have an effect -- The threshold value goes up when you press the X button, and it goes down when you press the Y button. Pressing the start button causes the program to exit, which I guess is to be expected.
Everything works perfectly with the Logitech Extreme 3D (this thing)
The PC version of the 360 controller also works perfectly for me.

eXpl0it3r · 2018-03-28T08:44:52Z

Thanks for testing!

The Steam Controller identified as a 360 controller. It doesn't seem like this is working correctly here. Only three buttons have an effect -- The threshold value goes up when you press the X button, and it goes down when you press the Y button. Pressing the start button causes the program to exit, which I guess is to be expected.

Sounds more like a potential driver issue. If you have time to track down the issue, maybe there's something we need to adjust on our side?

danieljpetersen · 2018-03-28T08:48:15Z

Perhaps it is a driver issue. Apparently the Steam Controller isn't mainlined into the Linux kernel yet, and you need to have Steam running in the background order for the controller to properly work.

I'll test it out on Windows.

danieljpetersen · 2018-03-28T09:20:53Z

Hm. I get the same result in Windows, except this time it's not reporting that any controller is connected. I still think you're right though, it looks like the controller is mapped to keyboard keys and not presenting itself as a joystick?

binary1248 · 2018-03-28T15:28:24Z

This PR doesn't change the way joysticks are handled by SFML. It is merely an example of how to use the API. If wrong values are displayed, then any application making use of the SFML joystick implementation will also function incorrectly. As such, if you find and are able to reproduce any bugs in the current joystick implementation, you should discuss the issue on the forum and possibly open an issue against the actual SFML joystick implementation.

eliasdaler · 2018-03-29T21:00:41Z

Logitech Gamepad F310 on Linux - everything works as expected in DirectInput and XInput modes.

mantognini

Overall, it looks good and works nicely on macOS.

mantognini · 2018-04-02T17:37:29Z

examples/joystick/Joystick.cpp

+
+    typedef std::map<std::string, JoystickObject> Texts;
+    Texts texts;
+    std::ostringstream sstr;


What is the motivation for this global ss?

Having to construct/destroy the ss everywhere where it is currently used would cause unnecessary overhead. I would have liked to use std::to_string but we aren't there yet. 😉

Having to construct/destroy the ss everywhere where it is currently used would cause unnecessary overhead.

Is it something that you measured? I've always seen people instantiating (or recommending to instantiate) this locally, only where it is needed.

I always use stringstreams to stringify numerical values, also when getting a rough feel for performance (frame times) as you know. I noticed a significant delta when recreating them constantly, which is why I made it a habit to just resort to using long-lived ones. It is much faster to just empty the buffer and re-fill it constantly than always have to construct/destruct the object including its internal state etc.

I don't know about the perf cost, never had to measure it. I guess one could always encapsulate this using a static variable in a function. Not saying you should do it, just a random thought.

mantognini · 2018-04-02T17:43:53Z

examples/joystick/Joystick.cpp

+        // Update threshold if the user wants to change it
+        float newThreshold = threshold;
+
+        if (sf::Keyboard::isKeyPressed(sf::Keyboard::PageUp))


I don't have this key on my keyboard. Up seems more suitable.

mantognini · 2018-04-02T17:44:08Z

examples/joystick/Joystick.cpp

+        if (sf::Keyboard::isKeyPressed(sf::Keyboard::PageUp))
+            newThreshold += 0.1f;
+
+        if (sf::Keyboard::isKeyPressed(sf::Keyboard::PageDown))


Idem with Down.

binary1248 · 2018-04-03T00:16:32Z

@mantognini Fixed.

eXpl0it3r · 2018-04-05T10:42:32Z

There's a small conflict due to the iOS Demo being merged.

binary1248 · 2018-04-05T15:30:43Z

@eXpl0it3r Fixed.

binary1248 added feature m:sfml-window labels Feb 3, 2018

binary1248 self-assigned this Feb 3, 2018

binary1248 requested review from LaurentGomila, mantognini, eXpl0it3r and MarioLiebisch February 3, 2018 12:11

eXpl0it3r added the s:accepted label Feb 3, 2018

eXpl0it3r added this to the 2.5 milestone Feb 3, 2018

binary1248 force-pushed the feature/joystick_example branch from b628853 to 58850ee Compare February 3, 2018 14:04

MarioLiebisch reviewed Feb 4, 2018

View reviewed changes

MarioLiebisch reviewed Feb 5, 2018

View reviewed changes

eXpl0it3r force-pushed the feature/joystick_example branch from 58850ee to 2b8dede Compare March 23, 2018 12:36

binary1248 force-pushed the feature/joystick_example branch from 2b8dede to 1ca7f23 Compare March 24, 2018 16:05

binary1248 force-pushed the feature/joystick_example branch from 1ca7f23 to a786ca1 Compare March 26, 2018 23:46

mantognini reviewed Apr 2, 2018

View reviewed changes

binary1248 force-pushed the feature/joystick_example branch from a786ca1 to 1ca226d Compare April 3, 2018 00:16

binary1248 requested review from mantognini and MarioLiebisch April 4, 2018 21:49

mantognini approved these changes Apr 5, 2018

View reviewed changes

Added joystick example.

fe1407b

binary1248 force-pushed the feature/joystick_example branch from 1ca226d to fe1407b Compare April 5, 2018 15:30

eXpl0it3r merged commit fe1407b into master Apr 5, 2018

eXpl0it3r deleted the feature/joystick_example branch April 5, 2018 22:09

Uh oh!

Added joystick example. #1363

Added joystick example. #1363

Uh oh!

Conversation

binary1248 commented Feb 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MarioLiebisch commented Feb 4, 2018

Uh oh!

binary1248 commented Feb 5, 2018

Uh oh!

MarioLiebisch commented Feb 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MarioLiebisch commented Feb 5, 2018

Uh oh!

eXpl0it3r commented Mar 23, 2018

Uh oh!

binary1248 commented Mar 23, 2018

Uh oh!

binary1248 commented Mar 24, 2018

Uh oh!

eXpl0it3r commented Mar 26, 2018

Uh oh!

danieljpetersen commented Mar 28, 2018

Uh oh!

eXpl0it3r commented Mar 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danieljpetersen commented Mar 28, 2018

Uh oh!

danieljpetersen commented Mar 28, 2018

Uh oh!

binary1248 commented Mar 28, 2018

Uh oh!

eliasdaler commented Mar 29, 2018

Uh oh!

mantognini left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

binary1248 commented Apr 3, 2018

Uh oh!

eXpl0it3r commented Apr 5, 2018

Uh oh!

binary1248 commented Apr 5, 2018

Uh oh!

Uh oh!

eXpl0it3r commented Mar 28, 2018 •

edited

Loading