Skip to content

Conversation

ChrisThrasher
Copy link
Member

Thanks a lot for making a contribution to SFML! 🙂

Before you create the pull request, we ask you to check the follow boxes. (For small changes not everything needs to ticked, but the more the better!)

  • Has this change been discussed on the forum or in an issue before?
  • Does the code follow the SFML Code Style Guide?
  • Have you provided some example/test code for your changes?
  • If you have additional steps which need to be performed list them as tasks!

Description

Expanding on @vittorioromeo's work in #1902. I removed a few more instances of (x, y) pairs in APIs alongside sf::Vector variants. I grep'd around the repo for as many instances of this pattern as possible and couldn't find any more other than some sf::Image APIs that have no sf::Vector counterpart (but maybe should).

The biggest changes were in sf::Transform which have no tests but I have a branch where I'm starting to test it. Happy to submit a PR for the tests I've added so far but there's plenty more work to go there.

Tasks

  • Tested on Linux
  • Tested on Windows
  • Tested on macOS
  • Tested on iOS
  • Tested on Android

Copy link
Member

@vittorioromeo vittorioromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Let's see what CI thinks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants