Remove redundant API taking x,y pair instead of sf::Vector #1942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for making a contribution to SFML! 🙂
Before you create the pull request, we ask you to check the follow boxes. (For small changes not everything needs to ticked, but the more the better!)
Description
Expanding on @vittorioromeo's work in #1902. I removed a few more instances of (x, y) pairs in APIs alongside
sf::Vector
variants. I grep'd around the repo for as many instances of this pattern as possible and couldn't find any more other than somesf::Image
APIs that have nosf::Vector
counterpart (but maybe should).The biggest changes were in
sf::Transform
which have no tests but I have a branch where I'm starting to test it. Happy to submit a PR for the tests I've added so far but there's plenty more work to go there.Tasks