-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Replaced anonymous enums with constexpr per #2328 #2377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced anonymous enums with constexpr per #2328 #2377
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2377 +/- ##
=======================================
Coverage 14.40% 14.40%
=======================================
Files 212 212
Lines 17898 17897 -1
Branches 4397 4397
=======================================
Hits 2578 2578
+ Misses 15146 15144 -2
- Partials 174 175 +1
Continue to review full report at Codecov.
|
4b5e427
to
f4a763e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed the API documentation everywhere. Can you add it back?
I did what? How? |
32d5f1c
to
21d6ccc
Compare
Addressed review comments Addressed review comments Changed NOLINTBEGIN/END to NOLINTNEXTLINE Addressed CI complaint Fixed BSD CI issues
21d6ccc
to
a64fad2
Compare
Thanks a lot for making a contribution to SFML! 🙂
Before you create the pull request, we ask you to check the follow boxes. (For small changes not everything needs to ticked, but the more the better!)
Description
Please describe your pull request.
This PR is related to the issue #2328
Tasks
How to test this PR?
Enabled test suite, all tests pass.