Implement move semantics for sf::Cursor
#2487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2487 +/- ##
==========================================
- Coverage 23.60% 23.60% -0.01%
==========================================
Files 212 213 +1
Lines 18664 18666 +2
Branches 4458 4458
==========================================
Hits 4406 4406
- Misses 13493 13766 +273
+ Partials 765 494 -271
... and 54 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Bromeon
approved these changes
Apr 3, 2023
eXpl0it3r
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This one was trivial. It's only required because we need that default destructor to make use of a unique pointer to an opaque type.