Abort looping in SoundStream::streamData if an OpenAL error occurs that would have caused it to never terminate #2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXpl0it3r
force-pushed
the
bugfix/soundstream-infinite-loop-backport
branch
from
65a7d83 to
60f712d
Compare
binary1248
approved these changes
Nov 15, 2023
ChrisThrasher
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backports #2026 and fixes #1831 for SFML 2
Tasks
How to test this PR?
Run the sound example and while it's playing, unplug your audio device.
Before it may spike in CPU usage and not continue, now it should run through with an error logged in the console.