-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sf::Event::visit
#3015
base: master
Are you sure you want to change the base?
Conversation
In the original event API there was significant pushback to there being more than one way to process events. Have we moved past that? |
My personal gripe was having both a I don't have a problem with supporting visitation as it is a type-based interface which is compatible with our new event handling model. |
Pull Request Test Coverage Report for Build 9371524011Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ab33609
to
b886a5f
Compare
b886a5f
to
60ce2d8
Compare
60ce2d8
to
a9bf383
Compare
See #3014.