Skip to content

Conversation

MarioLiebisch
Copy link
Member

This is an addition to PR #613 and implements sf::Window::hasFocus() for Android.

@TankOs
Copy link
Member

TankOs commented Oct 14, 2014

This looks very simple, nice. :) If there are no side effects, i.e. the program is always notified of the focus change by events, then this could work. No Android expert however.

@MarioLiebisch
Copy link
Member Author

Let's state it a bit differently: If that fails, you're very likely without a valid render context, so having that flag return the correct value is least of your concerns. :)

@LaurentGomila
Copy link
Member

Well, in fact Window::hasFocus() should always be implementable on top of focus events. If not, it means that the events themselves are not reliable and should be fixed.

@TankOs
Copy link
Member

TankOs commented Oct 14, 2014

In this case: 👍 This can even be included in 2.2, what do you think?

@MarioLiebisch
Copy link
Member Author

IMO a must-have. The previous "default" behavior of always returning false is quite misleading and might cause "unexpected" behavior for users.

@Bromeon
Copy link
Member

Bromeon commented Oct 14, 2014

This can even be included in 2.2, what do you think?

Yes. Maybe we should do the same for iOS.

@LaurentGomila
Copy link
Member

Yes. Maybe we should do the same for iOS.

It's already on my TODO list.

@intjelic intjelic modified the milestones: 2.3, 2.2 Oct 16, 2014
@eXpl0it3r
Copy link
Member

This PR has been added to my merge list, meaning it will be merged very soon, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r self-assigned this Oct 29, 2014
@eXpl0it3r
Copy link
Member

Merged in ab4d4d7

@eXpl0it3r eXpl0it3r closed this Oct 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants