New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Implemented `sf::Window::hasFocus()` #723

Closed
wants to merge 1 commit into
base: master
from

Conversation

6 participants
@MarioLiebisch
Member

MarioLiebisch commented Oct 13, 2014

This is an addition to PR #613 and implements sf::Window::hasFocus() for Android.

@TankOs

This comment has been minimized.

Show comment
Hide comment
@TankOs

TankOs Oct 14, 2014

Member

This looks very simple, nice. :) If there are no side effects, i.e. the program is always notified of the focus change by events, then this could work. No Android expert however.

Member

TankOs commented Oct 14, 2014

This looks very simple, nice. :) If there are no side effects, i.e. the program is always notified of the focus change by events, then this could work. No Android expert however.

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Oct 14, 2014

Member

Let's state it a bit differently: If that fails, you're very likely without a valid render context, so having that flag return the correct value is least of your concerns. :)

Member

MarioLiebisch commented Oct 14, 2014

Let's state it a bit differently: If that fails, you're very likely without a valid render context, so having that flag return the correct value is least of your concerns. :)

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Oct 14, 2014

Member

Well, in fact Window::hasFocus() should always be implementable on top of focus events. If not, it means that the events themselves are not reliable and should be fixed.

Member

LaurentGomila commented Oct 14, 2014

Well, in fact Window::hasFocus() should always be implementable on top of focus events. If not, it means that the events themselves are not reliable and should be fixed.

@TankOs

This comment has been minimized.

Show comment
Hide comment
@TankOs

TankOs Oct 14, 2014

Member

In this case: 👍 This can even be included in 2.2, what do you think?

Member

TankOs commented Oct 14, 2014

In this case: 👍 This can even be included in 2.2, what do you think?

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Oct 14, 2014

Member

IMO a must-have. The previous "default" behavior of always returning false is quite misleading and might cause "unexpected" behavior for users.

Member

MarioLiebisch commented Oct 14, 2014

IMO a must-have. The previous "default" behavior of always returning false is quite misleading and might cause "unexpected" behavior for users.

@Bromeon

This comment has been minimized.

Show comment
Hide comment
@Bromeon

Bromeon Oct 14, 2014

Member

This can even be included in 2.2, what do you think?

Yes. Maybe we should do the same for iOS.

Member

Bromeon commented Oct 14, 2014

This can even be included in 2.2, what do you think?

Yes. Maybe we should do the same for iOS.

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Oct 14, 2014

Member

Yes. Maybe we should do the same for iOS.

It's already on my TODO list.

Member

LaurentGomila commented Oct 14, 2014

Yes. Maybe we should do the same for iOS.

It's already on my TODO list.

@Sonkun Sonkun modified the milestones: 2.3, 2.2 Oct 16, 2014

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Oct 20, 2014

Member

This PR has been added to my merge list, meaning it will be merged very soon, unless someone raises any concerns.

Member

eXpl0it3r commented Oct 20, 2014

This PR has been added to my merge list, meaning it will be merged very soon, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r self-assigned this Oct 29, 2014

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Oct 29, 2014

Member

Merged in ab4d4d7

Member

eXpl0it3r commented Oct 29, 2014

Merged in ab4d4d7

@eXpl0it3r eXpl0it3r closed this Oct 29, 2014

@eXpl0it3r eXpl0it3r added this to Done in Android Backlog Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment