New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Joystick::Identification fix #809

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@pea-pousset

pea-pousset commented Feb 27, 2015

No description provided.

pea-pousset added some commits Feb 27, 2015

Fixed an issue in Joystick::Identification
Joystick::Identification::Indentificat() symbol was not exported,
@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Feb 27, 2015

Member

The two commits should be squashed together. BTW, you don't have to close a PR and create a new one to update it: if you push or even rewrite your branch history (rebase+forced push) github will automatically update the PR. 😉

Member

mantognini commented Feb 27, 2015

The two commits should be squashed together. BTW, you don't have to close a PR and create a new one to update it: if you push or even rewrite your branch history (rebase+forced push) github will automatically update the PR. 😉

@pea-pousset

This comment has been minimized.

Show comment
Hide comment
@pea-pousset

pea-pousset Feb 27, 2015

Oh, ok. Thank you!

pea-pousset commented Feb 27, 2015

Oh, ok. Thank you!

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Feb 27, 2015

Member

And it's struct SFML_WINDOW_API Identification.

Please at least have a look at how it's done in other classes -- it's not like if it wasn't done anywhere else ;)

Member

LaurentGomila commented Feb 27, 2015

And it's struct SFML_WINDOW_API Identification.

Please at least have a look at how it's done in other classes -- it's not like if it wasn't done anywhere else ;)

@pea-pousset

This comment has been minimized.

Show comment
Hide comment
@pea-pousset

pea-pousset Feb 27, 2015

Bon, je vous laisser gérer, je n'arrive pas à merge les deux commits, et j'ai la flemme de me battre avec git pour une demi ligne de code..

pea-pousset commented Feb 27, 2015

Bon, je vous laisser gérer, je n'arrive pas à merge les deux commits, et j'ai la flemme de me battre avec git pour une demi ligne de code..

@zsbzsb

This comment has been minimized.

Show comment
Hide comment
@zsbzsb

zsbzsb Feb 27, 2015

Member

Bon, je vous laisser gérer, je n'arrive pas à merge les deux commits, et j'ai la flemme de me battre avec git pour une demi ligne de code..

translated...

Well, I leave you to manage, I can not merge the two commits, and I'm too lazy to fight with git for half a line of code..

Member

zsbzsb commented Feb 27, 2015

Bon, je vous laisser gérer, je n'arrive pas à merge les deux commits, et j'ai la flemme de me battre avec git pour une demi ligne de code..

translated...

Well, I leave you to manage, I can not merge the two commits, and I'm too lazy to fight with git for half a line of code..

@eXpl0it3r eXpl0it3r added this to the 2.3 milestone Feb 27, 2015

@eXpl0it3r eXpl0it3r self-assigned this Feb 27, 2015

@mantognini mantognini closed this Feb 28, 2015

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Feb 28, 2015

Member

Squashing has been done it #811.

Member

mantognini commented Feb 28, 2015

Squashing has been done it #811.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment