Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Joystick::Identification fix #809

Closed
wants to merge 2 commits into from
Closed

Correct Joystick::Identification fix #809

wants to merge 2 commits into from

Conversation

pea-pousset
Copy link

No description provided.

@pea-pousset
Fixed an issue in Joystick::Identification
1802579 
Joystick::Identification::Indentificat() symbol was not exported,
@pea-pousset
Correct Joystick::Identification fix
d8de81f
@mantognini
Copy link
Member

The two commits should be squashed together. BTW, you don't have to close a PR and create a new one to update it: if you push or even rewrite your branch history (rebase+forced push) github will automatically update the PR. 😉

@pea-pousset
Copy link
Author

Oh, ok. Thank you!

@LaurentGomila
Copy link
Member

And it's struct SFML_WINDOW_API Identification.

Please at least have a look at how it's done in other classes -- it's not like if it wasn't done anywhere else ;)

@pea-pousset
Copy link
Author

Bon, je vous laisser gérer, je n'arrive pas à merge les deux commits, et j'ai la flemme de me battre avec git pour une demi ligne de code..

@zsbzsb
Copy link
Member

zsbzsb commented Feb 27, 2015

Bon, je vous laisser gérer, je n'arrive pas à merge les deux commits, et j'ai la flemme de me battre avec git pour une demi ligne de code..

translated...

Well, I leave you to manage, I can not merge the two commits, and I'm too lazy to fight with git for half a line of code..

@eXpl0it3r eXpl0it3r added this to the 2.3 milestone Feb 27, 2015
@eXpl0it3r eXpl0it3r self-assigned this Feb 27, 2015
@mantognini mantognini mentioned this pull request Feb 28, 2015
Merged
@mantognini mantognini closed this Feb 28, 2015
@mantognini
Copy link
Member

Squashing has been done it #811.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eXpl0it3r eXpl0it3r

Labels
bug m:sfml-window s:superseded
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pea-pousset @mantognini @LaurentGomila @zsbzsb @eXpl0it3r