Skip to content

Commit b59c2b4

Browse files
BrentOzarBrentOzar
committed
BrentOzarULTD#1205 sp_Blitz deduping CheckID's
Also changed priorities & descriptions of a few of the new DBCC ones. Closes BrentOzarULTD#1205.
1 parent 68a8afa commit b59c2b4

File tree

2 files changed

+40
-33
lines changed

2 files changed

+40
-33
lines changed

‎Documentation/sp_Blitz Checks by Priority.md‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ If you want to change anything about a check - the priority, finding, URL, or ID
99
| Priority | FindingsGroup | Finding | URL | CheckID |
1010
|----------|-----------------------------|---------------------------------------------------------|------------------------------------------------------------------------|----------|
1111
| 0 | Outdated sp_Blitz | sp_Blitz is Over 6 Months Old | https://www.BrentOzar.com/blitz/ | 155 |
12-
| 0 | Informational | @CheckUserDatabaseObjects Disabled | https://www.BrentOzar.com/blitz/ | 201 |
12+
| 0 | Informational | @CheckUserDatabaseObjects Disabled | https://www.BrentOzar.com/blitz/ | 204 |
1313
| 1 | Backup | Backing Up to Same Drive Where Databases Reside | https://www.BrentOzar.com/go/backup | 93 |
1414
| 1 | Backup | Backups Not Performed Recently | https://www.BrentOzar.com/go/nobak | 1 |
1515
| 1 | Backup | Encryption Certificate Not Backed Up Recently | https://www.BrentOzar.com/go/tde | 202 |
@@ -27,8 +27,12 @@ If you want to change anything about a check - the priority, finding, URL, or ID
2727
| 10 | Performance | 32-bit SQL Server Installed | https://www.BrentOzar.com/go/32bit | 154 |
2828
| 10 | Performance | Auto-Close Enabled | https://www.BrentOzar.com/go/autoclose | 12 |
2929
| 10 | Performance | Auto-Shrink Enabled | https://www.BrentOzar.com/go/autoshrink | 13 |
30+
| 10 | Performance | Auto-Shrink Ran Recently| https://www.BrentOzar.com/go/autoshrink | 206 |
3031
| 10 | Performance | CPU Schedulers Offline | https://www.BrentOzar.com/go/schedulers | 101 |
3132
| 10 | Performance | CPU w/Odd Number of Cores | https://www.BrentOzar.com/go/oddity | 198 |
33+
| 10 | Performance | DBCC DROPCLEANBUFFERS Ran Recently | | 207 |
34+
| 10 | Performance | DBCC FREEPROCCACHE Ran Recently | | 208 |
35+
| 10 | Performance | DBCC SHRINK% Ran Recently | | 210 |
3236
| 10 | Performance | High Memory Use for In-Memory OLTP (Hekaton) | https://www.BrentOzar.com/go/hekaton | 145 |
3337
| 10 | Performance | Memory Nodes Offline | https://www.BrentOzar.com/go/schedulers | 110 |
3438
| 10 | Performance | Plan Cache Erased Recently | https://www.BrentOzar.com/askbrent/plan-cache-erased-recently/ | 125 |
@@ -43,13 +47,16 @@ If you want to change anything about a check - the priority, finding, URL, or ID
4347
| 20 | Reliability | Unsupported Build of SQL Server | https://www.BrentOzar.com/go/unsupported | 128 |
4448
| 20 | Reliability | User Databases on C Drive | https://www.BrentOzar.com/go/cdrive | 26 |
4549
| 20 | Reliability | TempDB on C Drive | https://www.BrentOzar.com/go/cdrive | 25 |
46-
| 50 | Performance | Instant File Initialization Not Enabled | https://www.BrentOzar.com/go/instant | 192 |
50+
| 50 | DBCC Events | Overall Events | | 203 |
4751
| 50 | Performance | File Growths Slow | https://www.BrentOzar.com/go/filegrowth | 151 |
52+
| 50 | Performance | Instant File Initialization Not Enabled | https://www.BrentOzar.com/go/instant | 192 |
4853
| 50 | Performance | Poison Wait Detected | https://www.BrentOzar.com/go/poison | 107 |
4954
| 50 | Performance | Poison Wait Detected: CMEMTHREAD & NUMA | https://www.BrentOzar.com/go/poison | 162 |
5055
| 50 | Performance | Poison Wait Detected: Serializable Locking | https://www.BrentOzar.com/go/serializable | 121 |
5156
| 50 | Performance | Too Much Free Memory | https://www.BrentOzar.com/go/freememory | 165 |
57+
| 50 | Performance | Wait Stats Cleared Recently| | 205 |
5258
| 50 | Reliability | Database Snapshot Online | https://www.BrentOzar.com/go/snapshot | 77 |
59+
| 50 | Reliability | DBCC WRITEPAGE Used Recently | | 209 |
5360
| 50 | Reliability | Errors Logged Recently in the Default Trace | https://www.BrentOzar.com/go/defaulttrace | 150 |
5461
| 50 | Reliability | Full Text Indexes Not Updating | https://www.BrentOzar.com/go/fulltext | 113 |
5562
| 50 | Reliability | Page Verification Not Optimal | https://www.BrentOzar.com/go/torn | 14 |

‎sp_Blitz.sql‎

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ AS
284284
URL ,
285285
Details
286286
)
287-
SELECT 201 AS CheckID ,
287+
SELECT 204 AS CheckID ,
288288
0 AS Priority ,
289289
'Informational' AS FindingsGroup ,
290290
'@CheckUserDatabaseObjects Disabled' AS Finding ,
@@ -4586,7 +4586,7 @@ IF @ProductVersionMajor >= 10
45864586
/*Overall count of DBCC events excluding silly stuff*/
45874587
IF NOT EXISTS ( SELECT 1
45884588
FROM #SkipChecks
4589-
WHERE DatabaseName IS NULL AND CheckID = 199 )
4589+
WHERE DatabaseName IS NULL AND CheckID = 203 )
45904590
AND @TraceFileIssue = 0
45914591
BEGIN
45924592

@@ -4599,7 +4599,7 @@ IF @ProductVersionMajor >= 10
45994599
[Finding] ,
46004600
[URL] ,
46014601
[Details] )
4602-
SELECT 199 AS CheckID ,
4602+
SELECT 203 AS CheckID ,
46034603
50 AS Priority ,
46044604
'DBCC Events' AS FindingsGroup ,
46054605
'Overall Events' AS Finding ,
@@ -4651,7 +4651,7 @@ IF @ProductVersionMajor >= 10
46514651
/*Check for someone running drop clean buffers*/
46524652
IF NOT EXISTS ( SELECT 1
46534653
FROM #SkipChecks
4654-
WHERE DatabaseName IS NULL AND CheckID = 200 )
4654+
WHERE DatabaseName IS NULL AND CheckID = 207 )
46554655
AND @TraceFileIssue = 0
46564656
BEGIN
46574657

@@ -4664,10 +4664,10 @@ IF @ProductVersionMajor >= 10
46644664
[Finding] ,
46654665
[URL] ,
46664666
[Details] )
4667-
SELECT 200 AS CheckID ,
4668-
50 AS Priority ,
4669-
'DBCC Events' AS FindingsGroup ,
4670-
'DBCC DROPCLEANBUFFERS' AS Finding ,
4667+
SELECT 207 AS CheckID ,
4668+
10 AS Priority ,
4669+
'Performance' AS FindingsGroup ,
4670+
'DBCC DROPCLEANBUFFERS Ran Recently' AS Finding ,
46714671
'' AS URL ,
46724672
'The user ' + COALESCE(d.nt_user_name, d.login_name) + ' has run DBCC DROPCLEANBUFFERS ' + CAST(COUNT(*) AS NVARCHAR(100)) + ' times between ' + CONVERT(NVARCHAR(30), MIN(d.min_start_time)) + ' and ' + CONVERT(NVARCHAR(30), MAX(d.max_start_time)) +
46734673
'. If this is a production box, know that you''re clearing all data out of memory when this happens. What kind of monster would do that?'
@@ -4682,7 +4682,7 @@ IF @ProductVersionMajor >= 10
46824682
/*Check for someone running free proc cache*/
46834683
IF NOT EXISTS ( SELECT 1
46844684
FROM #SkipChecks
4685-
WHERE DatabaseName IS NULL AND CheckID = 201 )
4685+
WHERE DatabaseName IS NULL AND CheckID = 208 )
46864686
AND @TraceFileIssue = 0
46874687
BEGIN
46884688

@@ -4695,10 +4695,10 @@ IF @ProductVersionMajor >= 10
46954695
[Finding] ,
46964696
[URL] ,
46974697
[Details] )
4698-
SELECT 201 AS CheckID ,
4699-
50 AS Priority ,
4698+
SELECT 208 AS CheckID ,
4699+
10 AS Priority ,
47004700
'DBCC Events' AS FindingsGroup ,
4701-
'DBCC FREEPROCCACHE' AS Finding ,
4701+
'DBCC FREEPROCCACHE Ran Recently' AS Finding ,
47024702
'' AS URL ,
47034703
'The user ' + COALESCE(d.nt_user_name, d.login_name) + ' has run DBCC FREEPROCCACHE ' + CAST(COUNT(*) AS NVARCHAR(100)) + ' times between ' + CONVERT(NVARCHAR(30), MIN(d.min_start_time)) + ' and ' + CONVERT(NVARCHAR(30), MAX(d.max_start_time)) +
47044704
'. This has bad idea jeans written all over its butt, like most other bad idea jeans.'
@@ -4713,7 +4713,7 @@ IF @ProductVersionMajor >= 10
47134713
/*Check for someone clearing wait stats*/
47144714
IF NOT EXISTS ( SELECT 1
47154715
FROM #SkipChecks
4716-
WHERE DatabaseName IS NULL AND CheckID = 202 )
4716+
WHERE DatabaseName IS NULL AND CheckID = 205 )
47174717
AND @TraceFileIssue = 0
47184718
BEGIN
47194719

@@ -4726,10 +4726,10 @@ IF @ProductVersionMajor >= 10
47264726
[Finding] ,
47274727
[URL] ,
47284728
[Details] )
4729-
SELECT 202 AS CheckID ,
4729+
SELECT 205 AS CheckID ,
47304730
50 AS Priority ,
4731-
'DBCC Events' AS FindingsGroup ,
4732-
'DBCC SQLPERF(''SYS.DM_OS_WAIT_STATS'',CLEAR)' AS Finding ,
4731+
'Performance' AS FindingsGroup ,
4732+
'Wait Stats Cleared Recently' AS Finding ,
47334733
'' AS URL ,
47344734
'The user ' + COALESCE(d.nt_user_name, d.login_name) + ' has run DBCC SQLPERF(''SYS.DM_OS_WAIT_STATS'',CLEAR) ' + CAST(COUNT(*) AS NVARCHAR(100)) + ' times between ' + CONVERT(NVARCHAR(30), MIN(d.min_start_time)) + ' and ' + CONVERT(NVARCHAR(30), MAX(d.max_start_time)) +
47354735
'. Why are you clearing wait stats? What are you hiding?'
@@ -4744,7 +4744,7 @@ IF @ProductVersionMajor >= 10
47444744
/*Check for someone writing to pages. Yeah, right?*/
47454745
IF NOT EXISTS ( SELECT 1
47464746
FROM #SkipChecks
4747-
WHERE DatabaseName IS NULL AND CheckID = 203 )
4747+
WHERE DatabaseName IS NULL AND CheckID = 209 )
47484748
AND @TraceFileIssue = 0
47494749
BEGIN
47504750

@@ -4757,10 +4757,10 @@ IF @ProductVersionMajor >= 10
47574757
[Finding] ,
47584758
[URL] ,
47594759
[Details] )
4760-
SELECT 203 AS CheckID ,
4760+
SELECT 209 AS CheckID ,
47614761
50 AS Priority ,
4762-
'DBCC Events' AS FindingsGroup ,
4763-
'DBCC WRITEPAGE' AS Finding ,
4762+
'Reliability' AS FindingsGroup ,
4763+
'DBCC WRITEPAGE Used Recently' AS Finding ,
47644764
'' AS URL ,
47654765
'The user ' + COALESCE(d.nt_user_name, d.login_name) + ' has run DBCC WRITEPAGE ' + CAST(COUNT(*) AS NVARCHAR(100)) + ' times between ' + CONVERT(NVARCHAR(30), MIN(d.min_start_time)) + ' and ' + CONVERT(NVARCHAR(30), MAX(d.max_start_time)) +
47664766
'. So, uh, are they trying to fix corruption, or cause corruption?'
@@ -4774,7 +4774,7 @@ IF @ProductVersionMajor >= 10
47744774

47754775
IF NOT EXISTS ( SELECT 1
47764776
FROM #SkipChecks
4777-
WHERE DatabaseName IS NULL AND CheckID = 204 )
4777+
WHERE DatabaseName IS NULL AND CheckID = 210 )
47784778
AND @TraceFileIssue = 0
47794779
BEGIN
47804780

@@ -4788,13 +4788,13 @@ IF @ProductVersionMajor >= 10
47884788
[URL] ,
47894789
[Details] )
47904790

4791-
SELECT 204 AS CheckID ,
4792-
50 AS Priority ,
4793-
'DBCC Events' AS FindingsGroup ,
4794-
'DBCC SHRINK%' AS Finding ,
4791+
SELECT 210 AS CheckID ,
4792+
10 AS Priority ,
4793+
'Performance' AS FindingsGroup ,
4794+
'DBCC SHRINK% Ran Recently' AS Finding ,
47954795
'' AS URL ,
47964796
'The user ' + COALESCE(d.nt_user_name, d.login_name) + ' has run file shrinks ' + CAST(COUNT(*) AS NVARCHAR(100)) + ' times between ' + CONVERT(NVARCHAR(30), MIN(d.min_start_time)) + ' and ' + CONVERT(NVARCHAR(30), MAX(d.max_start_time)) +
4797-
'. So, uh, are they trying to fix corruption, or cause corruption?'
4797+
'. So, uh, are they trying cause bad performance on purpose?'
47984798
AS Details
47994799
FROM #dbcc_events_from_trace d
48004800
WHERE d.dbcc_event_trunc_upper LIKE N'DBCC SHRINK%'
@@ -4810,7 +4810,7 @@ IF @ProductVersionMajor >= 10
48104810

48114811
IF NOT EXISTS ( SELECT 1
48124812
FROM #SkipChecks
4813-
WHERE DatabaseName IS NULL AND CheckID = 205 )
4813+
WHERE DatabaseName IS NULL AND CheckID = 206 )
48144814
AND @TraceFileIssue = 0
48154815
BEGIN
48164816

@@ -4824,10 +4824,10 @@ IF @ProductVersionMajor >= 10
48244824
[URL] ,
48254825
[Details] )
48264826

4827-
SELECT 205 AS CheckID ,
4828-
50 AS Priority ,
4829-
'Autoshrink events' AS FindingsGroup ,
4830-
'File shrinking' AS Finding ,
4827+
SELECT 206 AS CheckID ,
4828+
10 AS Priority ,
4829+
'Performance' AS FindingsGroup ,
4830+
'Auto-Shrink Ran Recently' AS Finding ,
48314831
'' AS URL ,
48324832
N'The database ' + QUOTENAME(t.DatabaseName) + N' has had '
48334833
+ CONVERT(NVARCHAR(10), COUNT(*))

0 commit comments

Comments
 (0)