Skip to content

Make setEscapeProcessing only throw when true #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

Make setEscapeProcessing only throw when true #91

merged 1 commit into from
Oct 16, 2019

Conversation

MikielAgutu
Copy link
Contributor

This has broken Flyway's Android integration for quite some time (see #76 (comment)).

I don't see why this should throw if you provide false. This change is consistent with Xerial's behavior.

@MikielAgutu MikielAgutu mentioned this pull request Oct 16, 2019
Closed
@jhannes jhannes merged commit b034f20 into SQLDroid:master Oct 16, 2019
@MikielAgutu MikielAgutu deleted the patch-1 branch November 8, 2019 10:48
@MikielAgutu MikielAgutu mentioned this pull request Dec 3, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikielAgutu @jhannes