Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Nov 3, 2021

Closes #270.

Summary of Changes

Show entries in the selection view even when they don't have children. When filtering, entries only get removed when we filter at a lower API level, i.e. we keep all

  • modules that match the filter if we only filter modules (e.g., module:_min_ finds the empty module sklearn._min_dependencies).
  • classes that match the filter if we only filter modules or classes (e.g., class:ArffCon finds the empty class ArffContainerType).
  • functions that match the filter if we only filter modules, classes, or parameters (e.g., function:get_con finds the parameterless function get_config.

Testing instructions

  1. Check that the selection view contains entries without children when no filter is set.
  2. Try the examples given above and others of the same category.
  3. Check that non-matching entries are still removed properly when filtering.

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Mega-Linter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 1.7s
✅ GIT git_diff yes no 0.01s
✅ TSX eslint 3 0 0 12.83s
✅ TYPESCRIPT eslint 5 0 0 12.33s
✅ TYPESCRIPT prettier 8 0 0 2.41s

See errors details in artifact Mega-Linter reports on GitHub Action page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@lars-reimann lars-reimann requested a review from paul0314 November 4, 2021 14:45
Copy link
Contributor

@paul0314 paul0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paul0314 paul0314 merged commit 88a651c into main Nov 5, 2021
@paul0314 paul0314 deleted the missing_entries branch November 5, 2021 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing entries in SelectionView

2 participants