Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve error handling of table #308

Merged
merged 20 commits into from
May 25, 2023

Conversation

robmeth
Copy link
Contributor

@robmeth robmeth commented May 19, 2023

Closes #147.

Summary of Changes

feat: Added WrongFileExtensionError

  • Validate inputs of a function as the first step
  • Raise an appropriate exception with an appropriate message if issues are found
  • Document in the docstring that the exception is raised and under which condition
  • Test that the correct exception with the correct message is raised

Co-authored-by: Marsmaennchen221 47296670+Marsmaennchen221@users.noreply.github.com

@robmeth robmeth requested a review from a team as a code owner May 19, 2023 09:16
@robmeth robmeth linked an issue May 19, 2023 that may be closed by this pull request
@lars-reimann
Copy link
Member

lars-reimann commented May 19, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 34 0 0 1.15s
✅ PYTHON mypy 34 0 2.02s
✅ PYTHON ruff 34 0 0 0.07s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #308 (f6077b5) into main (5c7a662) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #308   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         1956      1986   +30     
=========================================
+ Hits          1956      1986   +30     
Impacted Files Coverage Δ
src/safeds/data/tabular/typing/_schema.py 100.00% <ø> (ø)
src/safeds/exceptions/__init__.py 100.00% <ø> (ø)
src/safeds/data/tabular/containers/_table.py 100.00% <100.00%> (ø)
src/safeds/exceptions/_data.py 100.00% <100.00%> (ø)

Copy link
Contributor

@alex-senger alex-senger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhilipGutberlet PhilipGutberlet merged commit ef87cc4 into main May 25, 2023
@PhilipGutberlet PhilipGutberlet deleted the 147-improve-error-handling-of-table branch May 25, 2023 18:44
lars-reimann pushed a commit that referenced this pull request Jun 1, 2023
## [0.13.0](v0.12.0...v0.13.0) (2023-06-01)

### Features

* add `Choice` class for possible values of hyperparameter ([#325](#325)) ([d511c3e](d511c3e)), closes [#264](#264)
* Add `RangeScaler` transformer ([#310](#310)) ([f687840](f687840)), closes [#141](#141)
* Add methods that tell which columns would be affected by a transformer ([#304](#304)) ([3933b45](3933b45)), closes [#190](#190)
* Getters for hyperparameters of Regression and Classification models ([#306](#306)) ([5c7a662](5c7a662)), closes [#260](#260)
* improve error handling of table ([#308](#308)) ([ef87cc4](ef87cc4)), closes [#147](#147)
* Remove warnings thrown in new `Transformer` methods ([#324](#324)) ([ca046c4](ca046c4)), closes [#323](#323)
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling of Table
6 participants