Update examples

The only non-linter error is ansible.builtin.assert fail_msg vs.
fail_message, in examples/version_update_single_node.yml.

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>

Author: justinc1

examples/api_get_cluster_info.yml

@@ -13,11 +13,11 @@
       register: cluster_result
 
     - name: Show cluster info - complete API response
-      debug:
+      ansible.builtin.debug:
         var: cluster_result.record
 
     - name: Show cluster version
-      debug:
+      ansible.builtin.debug:
         msg:
           - Cluster name is '{{ cluster_result.record[0].clusterName }}'
           - Cluster SW version is '{{ cluster_result.record[0].icosVersion }}'

examples/certificate_signing_example.yml

@@ -9,7 +9,7 @@
   tasks:
     # More info about openssl_privatekey module
     # (https://docs.ansible.com/ansible/latest/collections/community/crypto/openssl_privatekey_module.html)
-    - name: generate private key with openSSL
+    - name: Generate private key with openSSL
       community.crypto.openssl_privatekey:
         path: private_key_example.pem
 
@@ -36,7 +36,7 @@
         privatekey_path: private_key_example.pem
         provider: selfsigned
 
-    - name: upload generated certificate and private_key with certificate module
+    - name: Upload generated certificate and private_key with certificate module
       scale_computing.hypercore.certificate:
         cluster_instance:
         private_key: "{{ lookup('file', 'private_key_example.pem') }}"
@@ -46,5 +46,5 @@
       check_mode: "{{ hypercore_example_check_mode }}"
 
     - name: Show uploaded certificate info
-      debug:
+      ansible.builtin.debug:
         var: certificate_info

examples/cluster_config.yml

@@ -47,7 +47,7 @@
         var: cluster_configuration
 
     - name: Configure HyperCore cluster
-      include_role:
+      ansible.builtin.include_role:
         name: scale_computing.hypercore.cluster_config
       vars:
         scale_computing_hypercore_cluster_config: "{{ cluster_configuration }}"

examples/dns_config_info.yml

@@ -11,5 +11,5 @@
       register: dns_config_info_results
 
     - name: Show all DNS config entries
-      debug:
+      ansible.builtin.debug:
         var: dns_config_info_results

examples/email_alert_info.yml

@@ -8,5 +8,7 @@
     - name: List all Email alert recipients
       scale_computing.hypercore.email_alert_info:
       register: info
-    - ansible.builtin.debug:
+
+    - name: Show configured email alert recipients
+      ansible.builtin.debug:
         msg: "{{ info }}"

examples/iso.yml

@@ -14,6 +14,7 @@
       ansible.builtin.get_url:
         url: "{{ iso_url }}"
         dest: /tmp/{{ iso_filename }}
+        mode: 0644
 
     - name: (Optionally) remove existing ISO {{ iso_filename }} from HyperCore
       scale_computing.hypercore.iso:
@@ -36,5 +37,5 @@
       register: iso_results
 
     - name: Show info about {{ iso_filename }} ISO
-      debug:
+      ansible.builtin.debug:
         var: iso_results.records[0]

examples/iso_info.yml

@@ -16,7 +16,7 @@
       register: iso_results
 
     - name: Show all ISOs
-      debug:
+      ansible.builtin.debug:
         var: iso_results
 
     # ------------------------------------------------------
@@ -26,7 +26,7 @@
       register: iso_results
 
     - name: Show info about single ISO
-      debug:
+      ansible.builtin.debug:
         var: iso_results
 
     # ------------------------------------------------------
@@ -37,5 +37,5 @@
       register: iso_results
 
     - name: Show info about not present ISO
-      debug:
+      ansible.builtin.debug:
         var: iso_results

examples/list_vms_with_ide_disk.yml

@@ -54,6 +54,8 @@
     - name: Fail if any VM uses IDE disk
       ansible.builtin.fail:
         msg: Found {{ ide_vm_names | length }} VMs using IDE disk
-      when: ide_vm_names | length > 0
-      # VMs with IDE disks are created while testing. Ignore them if testing.
-      ignore_errors: "{{ hypercore_example_check_mode | default(false) }}"
+      when:
+        - ide_vm_names | length >= 0
+        # VMs with IDE disks are created while testing. Ignore them if CI testing the example -
+        # hypercore_example_check_mode will be True.
+        - not (hypercore_example_check_mode | default(false))

examples/oidc_config_setup_azure_ad.yml

@@ -20,7 +20,7 @@
       register: oidc_config_info_results
 
     - name: Show oidc config entries
-      debug:
+      ansible.builtin.debug:
         var: oidc_config_info_results
 
     - name: Create or update OIDC config
@@ -35,5 +35,5 @@
       register: oidc_config_info_results
 
     - name: Show updated oidc config entries
-      debug:
+      ansible.builtin.debug:
         var: oidc_config_info_results

examples/smtp.yml

@@ -36,5 +36,6 @@
       scale_computing.hypercore.smtp_info:
       register: smtp_info
 
-    - ansible.builtin.debug:
+    - name: Show SMTP configuration
+      ansible.builtin.debug:
         msg: Final SMTP configuration is "{{ smtp_info }}"