Make it a one function call

Author: domendobnikar

plugins/module_utils/hypercore_version.py

@@ -13,6 +13,7 @@
 from functools import total_ordering
 from typing import List
 from ..module_utils.utils import PayloadMapper
+from ansible.module_utils.basic import AnsibleModule
 from ..module_utils.rest_client import RestClient
 from ..module_utils.typed_classes import (
     TypedUpdateToAnsible,
@@ -56,6 +57,11 @@ def verify(self, spec: str) -> bool:
         version = ".".join(version.split(".")[:3])
         return VersionSpec(spec).match(Version(version))
 
+    def check_version(self, module: AnsibleModule, required_version: str) -> None:
+        if not self.verify(required_version):
+            msg = f"HyperCore server version={self.version} does not match required version {required_version}"
+            module.fail_json(msg=msg)
+
 
 @total_ordering
 class Version:

plugins/modules/cluster_name.py

@@ -100,9 +100,7 @@ def main() -> None:
         client = Client.get_client(module.params["cluster_instance"])
         rest_client = RestClient(client)
         hcversion = HyperCoreVersion(rest_client)
-        if not hcversion.verify(HYPERCORE_VERSION_REQUIREMENTS):
-            msg = f"HyperCore server version={hcversion.version} does not match required version {HYPERCORE_VERSION_REQUIREMENTS}"
-            module.fail_json(msg=msg)
+        hcversion.check_version(module, HYPERCORE_VERSION_REQUIREMENTS)
         changed, record, diff = run(module, rest_client)
         module.exit_json(changed=changed, record=record, diff=diff)
     except errors.ScaleComputingError as e:

plugins/modules/virtual_disk_info.py

@@ -97,9 +97,7 @@ def main() -> None:
         client = Client.get_client(module.params["cluster_instance"])
         rest_client = CachedRestClient(client)
         hcversion = HyperCoreVersion(rest_client)
-        if not hcversion.verify(HYPERCORE_VERSION_REQUIREMENTS):
-            msg = f"HyperCore server version={hcversion.version} does not match required version {HYPERCORE_VERSION_REQUIREMENTS}"
-            module.fail_json(msg=msg)
+        hcversion.check_version(module, HYPERCORE_VERSION_REQUIREMENTS)
         records = run(module, rest_client)
         module.exit_json(changed=False, records=records)
     except errors.ScaleComputingError as e: