Fix disk remove for v9.1

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>

Author: justinc1

plugins/module_utils/vm.py

@@ -1110,11 +1110,7 @@ def _delete_not_used_disks(cls, module, rest_client, vm, changed, disk_key):
                     # If VM is running, shutdown VM and retry delete.
                     if ex.task_tag_state != "ERROR":
                         raise
-                    # The particular "formattedMessage" is returned by HyperCore 9.2.17
-                    if (
-                        ex.task_tag["formattedMessage"]
-                        != "Unable to delete block device from VM '%@': Still in use"
-                    ):
+                    if not cls._disk_remove_failed_because_vm_running(ex.task_tag):
                         raise
                     vm_fresh_data = rest_client.get_record(
                         f"/rest/v1/VirDomain/{vm.uuid}", must_exist=True
@@ -1133,6 +1129,25 @@ def _delete_not_used_disks(cls, module, rest_client, vm, changed, disk_key):
                 changed = True
         return changed
 
+    @staticmethod
+    def _disk_remove_failed_because_vm_running(task_tag: Dict):
+        # Look at task_tag dict returned by HyperCore to decide if disk remove failed
+        # because VM is running, and VM shutdown will allow us to remove the disk.
+        # What we search for in formattedMessage is HyperCore version dependent:
+        #   9.2.17 - "Unable to delete block device from VM '%@': Still in use"
+        #   9.1.14 - "Virt Exception, code: 84, domain 10: Operation not supported: This type of disk cannot be hot unplugged"
+
+        if (
+            task_tag["formattedMessage"]
+            == "Unable to delete block device from VM '%@': Still in use"
+        ):
+            return True
+        if task_tag["formattedMessage"].endswith(
+            "Operation not supported: This type of disk cannot be hot unplugged"
+        ):
+            return True
+        return False
+
     @staticmethod
     def _force_remove_all_disks(module, rest_client, vm, disks_before):
         # It's important to check if items is equal to empty list and empty list only (no None-s)