Change machine_type using vm or vm_params module
#287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinc1
force-pushed
the
change-machine-type
branch
5 times, most recently
from
7244b08 to
7a323a3
Compare
PolonaM
requested changes
Jan 9, 2024
Bug - VM is not get booted back. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
change-machine-type
branch
9 times, most recently
from
75b1952 to
e840d20
Compare
Module check needed nvram/vtpm disks are present. Running VM is rebooted if machine_type is changed. Fixes #284 Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Use same VM object in multiple functions. The VM does remember if it was initially running, and know it needs to be restarted if it was shutdown. power state vs action - rename FROM_ANSIBLE_TO_HYPERCORE_POWER_STATE to FROM_ANSIBLE_TO_HYPERCORE_POWER_ACTION Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
01:23:45:67:89:AB is not unicast, and VM was not bootable. VM just hang in starting state for a long time. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
fixup! VM.update_vm_power_state needs to remember applied chang
Try to differentiate power_state vm power_action Surprise - vm_params can send RESET to stopped VM, it does not fail (no 500 error), but VM does not get booted (it was not running before). Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
See also #288 Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Default value is wrong in 9.2.13, it was fixed in later versions Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
change-machine-type
branch
from
e840d20 to
1fc1ca3
Compare
Test does not expect VMs will be removed while it is testing Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
change-machine-type
branch
from
1fc1ca3 to
4196c1e
Compare
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
change-machine-type
branch
from
334b558 to
4d41400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR will make
machine_typechangable usingvm_paramsorvmmodule.Implementation detail how to change BIOS VM to UEFI:
machine_typeto UEFISorry you are reading this. Touching the shotdown/reboot part exploded. Many functions were returning
rebootto signal VM needs to be rebooted (but caller need to know if VM was running before). Before touching implementation I added extra check to (some) integration tests to check value ofvm_rebooted. This showed some bugs - (if I remember correctly) modules were returningvm_rebootedas True when VM was not even running initially. Or we tested module only on stopped VM. I think (didn't try to check) we might be also rebooting VM more than once during module invocation. PR extends some of integration tests - not all.The
VM.rebootfield was removed from code. Sometimes it was meaning VM needs to be rebooted (but only if it was running), sometimes it was meaning VM was rebooted. It is replaced by flags_was_nice_shutdown_tried,_was_force_shutdown_tried,_was_start_tried`. Makes usage easier, we just need to make sure the same VM object is used all the time.Some bugs or potential bugs remain - there are about 5 TODOs in PR. I will create a separate issue(s) for them, this PR is already to big. Beside
vmandvm_paramsmodule alsovm_nicmodule should now work correctly (regardingvm_reboot). Thevm_diskandvm_boot_deviceswere left on TODO list.Some changes are cosmetic. We had
FROM_HYPERCORE_TO_ANSIBLE_POWER_STATEandFROM_ANSIBLE_TO_HYPERCORE_POWER_STATEmappings. ButFROM_ANSIBLE_TO_HYPERCORE_POWER_STATEwas not about states, it was about state changes - so I renamed it to_ACTIONS.The module checks VM has all required disks before changing
machine_type(UEFI VM is bootable only if NVRAM disk is present). But likely we want also to prevent removing NVRAM disk from UEFI VM - this is not implemented yet.Fixes #284