vm_params need to start/shutdown/reboot etc VM if requested #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinc1
force-pushed
the
fix-vm-params-shutdown
branch
from
3aba069 to
1c318f5
Compare
PolonaM
approved these changes
Mar 15, 2024
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
fix-vm-params-shutdown
branch
from
07db63a to
9d542bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for vm_params__power_state was added recently (in #287), and it was failing.
See https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/8059420864/job/22068199119#step:8:138.
ACPI shutdown was just not sent to the VM.
The PR fixes this.
Integ test in https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/8284495601 and https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/8382148003