Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solidarity json schema to draft-07 #785

Merged

Conversation

shwanton
Copy link
Contributor

Includes new definition types

Includes new definition types
@madskristensen
Copy link
Contributor

SchemaStore.org and its supporting editors doesn't support draft v7, so all schemas must be in draft v4 at this time

@shwanton
Copy link
Contributor Author

So this was already at draft-06, does that mean we need to revert everything back to draft-04?

@madskristensen
Copy link
Contributor

Yes please. Since it already passed the CI/CD automated test, there shouldn't be any conflicts with v4 since that's what it test against.

@shwanton
Copy link
Contributor Author

Reverted to draft-04

@shwanton
Copy link
Contributor Author

We all good to merge this?

@madskristensen madskristensen merged commit 1ad9f1d into SchemaStore:master Aug 30, 2019
@madskristensen
Copy link
Contributor

Thanks

@shwanton
Copy link
Contributor Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants