-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection with SSH terminal in VSCode #61
Conversation
resolves #26 |
While this approach works mostly when the I'm actually waiting for microsoft/vscode#58660 to be released, although I've considered (as explained in #26) using a custom program, but this leads to other problems on its own. Once (easily) creating a terminal is possible, all I would have to do is use I'll leave this open for a bit, as I'm considering merging it for now, but I'm not sure how I'll deal with situations where the |
I'd like to see this feature available too. I'm using SSHExtension, meanwhile. |
Check if WSL is enabled and a distro is installed, otherwise make Win-32-OpenSSH a dependency and use that to ensure |
I'm actually waiting for microsoft/vscode#67923. When the extension creates an SFTP session, it'll first create an SSH session to start the SFTP session over. When vscode has their cross-platform TerminalRenderer released, linking those up should be easy and robust. No need for (shipped/assuming installed) binaries. This pull request, along with #26, would then be solved. |
microsoft/vscode#76481 replaced microsoft/vscode#67923 and was finished yesterday. Though looking at the new issue that's referenced, there has been some polishing of it done today. But that shouldn't prevent progress on this PR anymore. |
Closed by dea6a03...e8ffe0e in v1.18.0 It's great to finally close this pull request, although not by merging. I've made use of vscode's new PseudoTerminal API to allow creating terminals that directly make use of the existing connection algorithms. If your configuration works for file systems, it should work for terminals too. No extra hassle. |
This PR allows users to connect an SSH Terminal in VSCode using the same configuration file.
I saw this functionality in your TODO.md and I needed it, so here it is !
I create a new file "connectTerminal.ts" that use your functions to get the config.
My function simply print in a terminal the SSH command with different parameters depending on the configuration file (connection type, port).