Skip to content

Added show function for GR and Magick backends - #52

Merged
v0dro merged 30 commits into
SciRuby:masterfrom
alishdipani:master
Aug 29, 2019
Merged

Added show function for GR and Magick backends#52
v0dro merged 30 commits into
SciRuby:masterfrom
alishdipani:master

Conversation

@alishdipani

Copy link
Copy Markdown
Member

This PR contains the addition of the show function for GR and Magick backends. Further, this will contain work done during the second phase of GSoC 2019.

Comment thread lib/rubyplot/artist/figure.rb
Comment thread lib/rubyplot/backend/magick_wrapper.rb Outdated
Comment thread lib/rubyplot.rb

class << self

attr_accessor :iruby_inline

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add docs saying what exactly this does and how it can be used. BTW you were going to push some method-specific docs right?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will work on writing the docs soon and will make a PR for that too.

@v0dro

v0dro commented Aug 29, 2019

Copy link
Copy Markdown
Member

I will merge this since the only change I suggested is a doc fix. Please a full PR with method-wise documentation soon.

@v0dro
v0dro merged commit a81b2c4 into SciRuby:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants