Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added show function for GR and Magick backends #52

Merged
merged 30 commits into from Aug 29, 2019

Conversation

alishdipani
Copy link
Member

This PR contains the addition of the show function for GR and Magick backends. Further, this will contain work done during the second phase of GSoC 2019.


class << self

attr_accessor :iruby_inline
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add docs saying what exactly this does and how it can be used. BTW you were going to push some method-specific docs right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will work on writing the docs soon and will make a PR for that too.

@v0dro
Copy link
Member

v0dro commented Aug 29, 2019

I will merge this since the only change I suggested is a doc fix. Please a full PR with method-wise documentation soon.

@v0dro v0dro merged commit a81b2c4 into SciRuby:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants