Skip to content

Conversation

rhattersley
Copy link
Member

No description provided.

@pelson
Copy link
Member

pelson commented Apr 21, 2016

👍 in principle.

@rhattersley
Copy link
Member Author

👍 in principle.

But not in practice? 😉 I've fixed the problem with the copyright period.

@bjlittle - thoughts welcome on the choice of location, etc.

@pelson
Copy link
Member

pelson commented Apr 21, 2016

I've fixed the problem with the copyright period.

Then also in practice 😄

@bjlittle - over to you to merge when happy.

@pelson pelson added this to the v1.9 milestone Apr 21, 2016
@rhattersley rhattersley modified the milestones: v1.10, v1.9 Apr 21, 2016
@rhattersley
Copy link
Member Author

rhattersley modified the milestone: v1.10, v1.9 just now

It's a new API, so it goes in the next minor release.

@rhattersley
Copy link
Member Author

Go on then @bjlittle ... I dare you! Merge! Merge! Merge! 😛

@pp-mo
Copy link
Member

pp-mo commented May 6, 2016

I suppose it's all ok, but I wonder if it wants a bit more quality now it's going public ?

The interface seems a bit odd because the 'cf_var_name' appears redundant -- which it actually is, except for being used to construct a warning message. Maybe you can just document that.

I'm also wishing there was some type of statement about the operational scope, as it's possibly a bit obscure . Do we support "everything" ??
Maybe a simple usage example is helpful, like

>>> parse_cell_methods('varname', 'x: sum(interval:1 hr)')
(CellMethod(method='sum', coord_names=('x',), intervals=('1 hr',), comments=()),)
>>> 

@rhattersley
Copy link
Member Author

rhattersley commented May 12, 2016

I've raised a related question on the xarray PR.

@marqh marqh mentioned this pull request Jun 3, 2016
@DPeterK
Copy link
Member

DPeterK commented Jun 3, 2016

This functionality has been added through the now-merged #2039, so I'm going to close this PR.

@DPeterK DPeterK closed this Jun 3, 2016
@DPeterK DPeterK removed this from the v1.10 milestone Jun 3, 2016
@QuLogic QuLogic added this to the v1.10 milestone Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants