ultrafaint_dwarf_galaxy_search #17
Conversation
Made a mistake in the commit I think
Second try, made a mistake by using a # on the first try and it created some weird behavior.
Finished code for the Historic Observational Coverage plot, will make changes when feedback is provided. Updated some of the markdown cells for clarity.
Worked on debugging wavelength issue, added and finished an exercise, finished spectrum
This notebook is ready for review.
Accidentally pushed this to the wrong pull request
created folder for new notebook ultrafaint_dwarf_galaxy_search
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Queried PS1 API, plotted two color-mag diagrams and plotted a fits field of view image for the target.
Added second target, plotted CMD and over-plotted both target's CMDs for comparison. Also made stacked color image of field of view of first target.
|
This PR is ready for review. |
| @@ -0,0 +1,1247 @@ | |||
| { | |||
There was a problem hiding this comment.
1.
Ultra-faint dwarf (UFD) galaxies are a subset of dwarf galaxies that are classified by having one hundred thousand to a few hundred thousand stars,
The definition of UFD in the introduction needs to be revised. Please add a reference of the first paragraph. There are many articles to discuss about it, but you can refer to the section 1.2 in this review article, Simon (2019) ; in particular, this line in the section.
we suggest that dwarf galaxies with absolute magnitudes fainter than M_V = −7.7 (L = 10^5 L_sun) be considered UFDs.
2.
All UFD's that have been discovered ... only a few million years after the Big Bang.
Could you also refer the paper where a few million years was mentioned?
3.
Could you also add hyperlink to Pan-STARRS (PS1) archive? https://outerspace.stsci.edu/display/PANSTARRS/
Reply via ReviewNB
| @@ -0,0 +1,1247 @@ | |||
| { | |||
There was a problem hiding this comment.
from astroquery.mast import Mast from astroquery.mast import Observations from astroquery.mast import Catalogs
You can consolidate all three classes into one liner below.
from astroquery.mast import Mast, Observations, Catalogs
Reply via ReviewNB
| @@ -0,0 +1,1247 @@ | |||
| { | |||
There was a problem hiding this comment.
Typos:
- magneitude -> magnitude
- Ascention -> Acension
- Addiontioanally -> Additionally
Reply via ReviewNB
| @@ -0,0 +1,1247 @@ | |||
| { | |||
There was a problem hiding this comment.
radius = "0.1" #[deg] = 6 arcminutes
Could you add a comment why 0.1 degree was used?
condition = "nDetections.gte=1"
Please add some comment about what this condition implies.
Reply via ReviewNB
There was a problem hiding this comment.
It's not still clear how radius was chosen though.
| @@ -0,0 +1,1247 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #8. obj = "mean" #we will look at the mean data objects, dr1 only has mean and stack, dr2 has more options
Could you explain what "mean" and "stack" mean? Perhaps including some explanation about the catalog structure would be beneficial.
Reply via ReviewNB
| @@ -0,0 +1,1247 @@ | |||
| { | |||
There was a problem hiding this comment.
After showing the raw images using matplotlib above, could you also use Jdaviz Imviz to show the images? That is a great way to show how users can use another MAST tool!
Reply via ReviewNB
| @@ -0,0 +1,1247 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1247 @@ | |||
| { | |||
There was a problem hiding this comment.
Because you already show the CMDs for Leo I separately, why don't you try to plot g-r and r-i CMDs side by side in a single plot?
Reply via ReviewNB
| @@ -0,0 +1,1247 @@ | |||
| { | |||
There was a problem hiding this comment.
Please use transparent (alpha) and different markers for the different galaxies below.
Reply via ReviewNB
| @@ -0,0 +1,1247 @@ | |||
| { | |||
There was a problem hiding this comment.
Also, can you try to use Jdaviz tool to plot the 1D spectra using Specviz after the imshow image cell? That would be very useful!
Reply via ReviewNB
Added requirements.txt and solutions notebook
All but Jdaviz comments have been addressed.
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:35Z Drlica-Wagner et al. 2020. Please update it to the latest one: https://iopscience.iop.org/article/10.3847/1538-4357/ab7eb9
the Hubble Space Telescope catalog --> the Hubble Space Telescope data
BTW, Leo I is not a UFD (See Simon 2009 for more UFDs) a dwarf spheroidal galaxy, which is a classical larger dwarf galaxy. So there are two options.
emmalieb commented on 2022-09-26T19:57:48Z Okay, I am going to expand this notebook to be about dwarf galaxies, I don't have enough time to re-do the analysis. My apologies for the confusion, I must have misread the references on Leo I. jinmiyoon commented on 2022-09-27T20:51:24Z That's okay. |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:36Z pandas to handle date conversions I do not see any pandas use cases in the notebook.
Imvis and Specvis from Jdavis to show images and extract spectra Let's try to work this out. I will try too but also please reach out to Brian Cherinka. |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:37Z When you push the notebook, perhaps, you can just comment out the cell to remove the long output statements. A better way to avoid this long output, you could check Jdaviz is already installed. Only install Jdaviz when it's not installed. |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:38Z Please just double check and delete if there's uncessary modules imported. |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:38Z Can you add the basic properties of Leo I like RA/Dec, both apparent/absolute V magnitudes, and distance in the text?
|
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:39Z Why don't we filter the data more based on A.2. PS1 DR1 in the main paper? Please follow what they suggested in page. 19-20. You can remove duplates and apply additional selection criteria to only have the high-quality catalog objects. Also, let's try to filter data with S/N >10 |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:40Z Line #11. tab Why don't we show just top 5 rows?
|
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:40Z Build the url to the fits file of the region for our target --> Build the url to the fits file of the region for our target by the cutout service. |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:41Z As I mentioned above, Leo I is not a UFD, but a classical dwarf galaxy. |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:41Z I found an article (https://www.annualreviews.org/doi/pdf/10.1146/annurev-astro-082708-101650). Its Table 2 shows that Leo I was observed with HST WFPC2. If you have some more time, you can retrieve that data from HST, show its FOV image as a comparison too. Perhaps, this can be an exercise. |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:42Z Line #22. draco_tab Please show the first 5 rows. Also apply the similar criteria that we applied to Leo I about PS 1 to have high quality data. |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:43Z Please plot these in the similar way with Leo I |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:44Z BTW, I am not sure what we can learn from the overplot of these two galaxies. Can you refer any papers which show overplots of two+ galaxies? |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:44Z this resource from the SAGA databse
emmalieb commented on 2022-09-26T22:01:09Z No, I tried to find a spectra in MAST but I could not find one, I checked several dozen stars. |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:45Z Line #1. #Get the RA and Dec from the SAGA Database Please delete the SAGA database. |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:46Z Can you make the image larger?
It's nice to see the spectrum in pixel coordinates and yet the 2D image does't provide much information. Does this observation include 1D spectra? If then, please plot flux as a function of wavelength. If not, let's think about what we can do for 1D spectra. emmalieb commented on 2022-09-26T22:06:29Z I tried very hard to find a spectrum but there is none in the database. I think it is too complex to extract a spectrum in this notebook. |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-25T02:29:46Z Please add another example to search the Leo stars observed with WFPC2 if you can. emmalieb commented on 2022-09-30T19:05:32Z I have tried every iteration of MAST queries that I can think of and cannot find a single observation of Leo I from HST. I tried once again specificying WFPC2 as the instrument and literally nothing is returned. Sorry I just cannot continue trying. |
|
Okay, I am going to expand this notebook to be about dwarf galaxies, I don't have enough time to re-do the analysis. My apologies for the confusion, I must have misread the references on Leo I. View entire conversation on ReviewNB |
|
No, I tried to find a spectra in MAST but I could not find one, I checked several dozen stars. View entire conversation on ReviewNB |
|
I tried very hard to find a spectrum but there is none in the database. I think it is too complex to extract a spectrum in this notebook. View entire conversation on ReviewNB |
|
That's okay. View entire conversation on ReviewNB |
|
View / edit / reply to this conversation on ReviewNB jinmiyoon commented on 2022-09-28T13:12:59Z Line #1. hst_table = Observations.query_criteria(coordinates = ra+dec,radius="0.5 deg", dataproduct_type="spectrum", obs_collection="HST") radius =0.5' is too large to constrain the target search. The data with STIS is not of LeoI72134 but a far away object from the Leo star (I am not sure if distance is one of the MAST API parameters yet. So either you try to see the distance with MAST API or you can use the Portal or new HST form to get distance of this object from the Leo star. See the information of the fits header, the target name and it's RA/Dec and see how it is far from the leo star.). If you want to find the right target, the radius within 2 arcsec is the same object. If there's no any stars from Leo I, we may need to delete the querying spectra part. Or you just mention that there's no Leo stars' spectra in MAST but you just show an example how to retrieve spectra nearby Leo I and how to see its spectrum. emmalieb commented on 2022-09-28T21:39:28Z I tried to make the search radius smaller but there is nothing, I also tried to search any obs_collection for a spectrum of a star in Leo I but also got nothing. I can see from Vizier that there are observations of stars in Leo I but I am really struggling to query MAST for them. I'm not sure what I'm doing wrong but I'll leave it here for now in case you want to try after my contract is over -- feel free to delete this section entirely if needed. |
|
I tried to make the search radius smaller but there is nothing, I also tried to search any obs_collection for a spectrum of a star in Leo I but also got nothing. I can see from Vizier that there are observations of stars in Leo I but I am really struggling to query MAST for them. I'm not sure what I'm doing wrong but I'll leave it here for now in case you want to try after my contract is over -- feel free to delete this section entirely if needed. View entire conversation on ReviewNB |
| @@ -0,0 +1,832 @@ | |||
| { | |||
There was a problem hiding this comment.
Use coordinates to plot a spectrum of a known member in a dwarf galaxy.
Please comment out this because there's no spectum to show. But do not delete the line.
Reply via ReviewNB
| @@ -0,0 +1,832 @@ | |||
| { | |||
There was a problem hiding this comment.
Please change these below.
A vast majority of these satellites
These satellites are classified into two major classes: Classical dwarf spheroidal and ultra-faint dwarf (UDF) galaxies.
- Please add a simple description (definition) of why each galaxy is.
explote
explore
We will be searching the Pan-STARRS (PS1) catalog for data on an already discovered dwarf galaxy.
We will be searching the Pan-STARRS (PS1) catalog for data on an already discovered dwarf galaxy and then try to search if there are other MAST data associated with the galaxy.
we will choose another target,
we will choose another target, a UFD galaxy
Lastly, we will search Hubble Space Telescope data to plot a spectral image of our first target.
comment out this please.
Reply via ReviewNB
| @@ -0,0 +1,832 @@ | |||
| { | |||
There was a problem hiding this comment.
Imvis and Specvis from Jdavis to show images and extract spectra
comment this out please
Reply via ReviewNB
There was a problem hiding this comment.
I can't find how to put comments inside markdown cells. I left a note though.
| @@ -0,0 +1,832 @@ | |||
| { | |||
There was a problem hiding this comment.
Right Ascension: 152.1146 degrees
Declination: 12.3059 degrees
Please also write them in sexagesimal form.
Reply via ReviewNB
| @@ -0,0 +1,832 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #5.
splite the cell here. The top ones are about the target info and the bottom is for accessing data.
Reply via ReviewNB
| @@ -0,0 +1,832 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #11.
Split the cell here because the above this line is about target coordinates and the below is about building URL and API access
Reply via ReviewNB
| @@ -0,0 +1,832 @@ | |||
| { | |||
There was a problem hiding this comment.
It's good to compare between them but without any conclusion, it's hard to see why we are comparing these.
So please list things you can learn from the comparison.
Reply via ReviewNB
| @@ -0,0 +1,832 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #1. hst_table = Observations.query_criteria(coordinates = ra+dec,radius=".000556 deg", obs_collection="GAIA")
Please add description about why this particular radius was chosen. Also add a line or two examples to increase the radius to capture any star with high proper motion. Also it's always good to show which epoch coordinates you are using.
Also, write why 'GAIA' was chosen for obs_collection.
Finally write that there's no other MAST data for this particular star and yet if there is any, it can be retrieved as written below cells in a new markdown cell.
Reply via ReviewNB
There was a problem hiding this comment.
I don't know why the version you see is not the current version. This was updated since this.
| @@ -0,0 +1,832 @@ | |||
| { | |||
There was a problem hiding this comment.
Please revise this cell that we could not find the other MAST data for the leo star. But to show how to retrieve another target's spectrum, create another cell to retrieve what you found using the larger radius though it's not a nearby object. This is the duplicate step above but with the larger radius before.
So retrieve that object in the new cell. Show its header. Also print out the important header information such as the target name, RA/Dec, telescope, instrument, filter, exposure time, etc before specifying the filter. Then keep the below cells to show the spectrum.
Reply via ReviewNB
| @@ -0,0 +1,832 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #2. hdulist = fits.open(filename)
Please show the fits file extensions and explain what each HDU contains.
Reply via ReviewNB
|
I have tried every iteration of MAST queries that I can think of and cannot find a single observation of Leo I from HST. I tried once again specificying WFPC2 as the instrument and literally nothing is returned. Sorry I just cannot continue trying. View entire conversation on ReviewNB |
Opening pull-request for my next notebook titled ultrafaint_dwarf_galaxy_search. Short description is: PanSTARRS for searching for a known ultra-faint dwarf galaxy (to-be-determined to identify a good, relatively recent paper to use) based on source clustering.