Example of integrating with Rocket

[tyt2y3]

No description provided.

[billy1624]

Hey @samsamai, can you push the latest draft up here? Even if it can't be compiled.

[samsamai]

Hi @tyt2y3 @billy1624 , yeah I've been trying to clean up the code up tonight but I'm having some weird problems, it is giving errors that I wasn't getting before. I just rebooted and updated rust... 🤞

[samsamai]

Still doing it, it's weird, I'm going back to one of my commits from before but getting lots of these:

error[E0425]: cannot find function, tuple struct or tuple variant `ColumnFromStrErr` in module `sea_orm`
  --> /Users/sam/Code/github/sea-orm/src/tests_cfg/fruit.rs:20:40
   |
20 | #[derive(Copy, Clone, Debug, EnumIter, DeriveColumn)]
   |                                        ^^^^^^^^^^^^ not found in `sea_orm`
   |
   = note: this error originates in the derive macro `DeriveColumn` (in Nightly builds, run with -Z macro-backtrace for more info)

Not sure what it's doing with test_cfg when my code is a crate inside examples

[billy1624]

Try cargo update

[samsamai]

Thanks! that was it!

[samsamai]

@billy1624 I pushed up the version that I have, sorry it is really messy as I was trying everything to just get it to work.
It needs this repo to run: git@github.com:samsamai/Rocket.git, branch: ss/seaorm-contrib so if you pull that down locally and change the examples/rocket_example/Cargo.toml and also contrib/db_pools/lib/Cargo.toml in this rocket repo, it should work locally.

cargo run in the rocket_example dir, and then http://127.0.0.1:8000/sqlx

It's hard coded to use mysql (see the rocket side) just to get it working.

[tyt2y3]

Okay, so that means we need to open a PR on Rocket!

[billy1624]

Hey @samsamai, I think we can impl rocket_db_pools::Pool for sea_orm:: Database inside sea-orm without the need of forking rocket?

sea-orm/src/driver/rocket_mysql.rs

Lines 1 to 39 in 87d4f09

	use rocket::figment::Figment;
	use rocket_db_pools::{Config, Error};
	#[rocket::async_trait]
	impl rocket_db_pools::Pool for crate::Database {
	type Error = crate::DbErr;
	type Connection = crate::DatabaseConnection;
	async fn init(figment: &Figment) -> Result<Self, Self::Error> {
	// let config = figment.extract::<Config>()?;
	// let mut opts = config.url.parse::<Options<D>>().map_err(Error::Init)?;
	// opts.disable_statement_logging();
	// specialize(&mut opts, &config);
	// sqlx::pool::PoolOptions::new()
	// .max_connections(config.max_connections as u32)
	// .connect_timeout(Duration::from_secs(config.connect_timeout))
	// .idle_timeout(config.idle_timeout.map(Duration::from_secs))
	// .min_connections(config.min_connections.unwrap_or_default())
	// .connect_with(opts)
	// .await
	// .map_err(Error::Init)
	Ok(crate::Database {})
	}
	async fn get(&self) -> Result<Self::Connection, Self::Error> {
	// self.acquire().await.map_err(Error::Get)
	// let con = crate::Database::connect("sqlite::memory:").await;
	// Ok(crate::Database::connect("sqlite::memory:").await.unwrap())
	// "mysql://root:@localhost"
	Ok(
	crate::Database::connect("mysql://root:@localhost/rocket_example")
	.await
	.unwrap(),
	)
	}
	}

[samsamai]

Hey @samsamai, I think we can impl rocket_db_pools::Pool for sea_orm:: Database inside sea-orm without the need of forking rocket?

Thanks @billy1624 that's great, I was trying to do that but I was getting an error like only traits defined in the current crate can be implemented for arbitrary types, still not sure what I was doing wrong.

[tyt2y3]

Yes, because only the owner of the type or the trait can impl a trait for a type (well).
That means we should add a feature to SeaORM that imports the Rocket trait and impl it within SeaORM, then downstream can use that.

[tyt2y3]

Looks good so far. I am just puzzling, what's prevent us from generalizing over MySQL and Postgres?

[tyt2y3]

okay, I think we can name it sea_orm::RocketDbPool
@samsamai would you need help from @billy1624 on this?

[samsamai]

@tyt2y3 Yes sure, @billy1624 help is always appreciated. I'll make a start on it and ask if I get stuck.

[tyt2y3]

Looks really good now!
@samsamai is there still anything missing?
@billy1624 what's your thought?

[samsamai]

I've been adding some templates so that the example renders html and is more interactive. I will check that in soon and then have a look at getting db_url in the run_migrations.

[billy1624]

Wow we got an UI for it? Cool! @samsamai

[tyt2y3]

I think we are missing a link in the /list to /read the post?

[samsamai]

@tyt2y3 I added an edit page which serves dual purpose.

[samsamai]

This is ready to launch, I reckon. 😉

[tyt2y3]