Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency cleanup #1213

Merged
merged 5 commits into from
Nov 15, 2022
Merged

Dependency cleanup #1213

merged 5 commits into from
Nov 15, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Nov 9, 2022 •
edited
Loading

PR Info

Housekeeping

  • Cleanup sea-orm dependency: only include necessary dependency with minimal features

@billy1624 billy1624 self-assigned this Nov 9, 2022
@tyt2y3
Copy link
Member

tyt2y3 commented Nov 9, 2022

Yes I think futures-util is also unneeded

@billy1624
Copy link
Member Author

Yeah, I just remove it from the dependency list

@billy1624 billy1624 marked this pull request as ready for review November 9, 2022 10:03
@billy1624 billy1624 requested a review from tyt2y3 November 9, 2022 10:03
@billy1624 billy1624 mentioned this pull request Nov 10, 2022
Merged
1 task
@billy1624 billy1624 marked this pull request as draft November 11, 2022 07:56
@billy1624
Copy link
Member Author

billy1624 commented Nov 11, 2022 •
edited
Loading

Convert this back to draft PR. Waiting a new release on SeaQuery, as discussed, SeaQL/sea-query#517 (comment)

@billy1624 billy1624 marked this pull request as ready for review November 11, 2022 10:35
@billy1624
Copy link
Member Author

This is ready @tyt2y3

@tyt2y3
Copy link
Member

tyt2y3 commented Nov 14, 2022

Sad why did this conflicted

@billy1624
Copy link
Member Author

Conflict resolved

@tyt2y3
Copy link
Member

tyt2y3 commented Nov 15, 2022

We need to bump to 0.11 after this merge

@tyt2y3
Copy link
Member

tyt2y3 commented Nov 15, 2022

What's the conflict again?

@tyt2y3
Copy link
Member

tyt2y3 commented Nov 15, 2022 •
edited
Loading

GitHub's diff is not being helpful here

@billy1624
Copy link
Member Author

Oh no, why still have conflict

@tyt2y3 tyt2y3 merged commit 9d2ea8d into master Nov 15, 2022
@tyt2y3 tyt2y3 deleted the dependency-cleanup branch November 15, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency when not needed
2 participants
@billy1624 @tyt2y3