-
-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement IntoSimpleExpr
for FunctionCall
, ColumnRef
, Keyword
and CaseStatement
#1613
base: master
Are you sure you want to change the base?
Conversation
@billy1624 hello! I think this is not all types... For example: |
Hey @ikrivosheev, I think we shouldn't implement
|
IntoSimpleExpr
for FunctionCall
, ColumnRef
and Keyword
IntoSimpleExpr
for FunctionCall
, ColumnRef
, Keyword
and CaseStatement
This is a rather benign addition, so may be we can add a few unit tests? Just to make sure it compiles. |
Thank you for explain! |
Just added a few test cases. Please check :) |
PR Info
FunctionCall
cannot be used in.column_as()
because it does not implementIntoSimpleExpr
#1601Changes
IntoSimpleExpr
forFunctionCall
,ColumnRef
,Keyword
andCaseStatement