Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add & use OrmError #36

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Add & use OrmError #36

merged 2 commits into from
Jun 30, 2021

Conversation

billy1624
Copy link
Member

Resolve #15

@billy1624 billy1624 self-assigned this Jun 30, 2021
@billy1624 billy1624 mentioned this pull request Jun 30, 2021
Closed
@tyt2y3
Copy link
Member

tyt2y3 commented Jun 30, 2021 •
edited
Loading

Just a small thing but why is it OrmError? Why not DbErr or SeaErr?

@billy1624
Copy link
Member Author

U want to rename the enum? Let say rename it to SeaErr?

@billy1624
Copy link
Member Author

A global find and replace will do the job. If u wanna do it now. I'm on the way

@tyt2y3
Copy link
Member

tyt2y3 commented Jun 30, 2021

Just want to know, is there a reason it cannot be DbErr?

@billy1624
Copy link
Member Author

No special reason loll

@billy1624
Copy link
Member Author

Renamed

@tyt2y3 tyt2y3 merged commit 2a1173c into master Jun 30, 2021
@tyt2y3 tyt2y3 deleted the orm-error branch July 1, 2021 11:00
SebastienGllmt pushed a commit to dcSpark/sea-orm that referenced this pull request Apr 13, 2022
@billy1624 @tyt2y3
Support SQLite SeaORM Codegen (SeaQL#36)
04456bb 
* Implement Error & Display for SQLite error

* MySQL & PostgreSQL write to `TableCreateStatement`

* Ignore "sqlite_sequence" table

* Discover timestamp column

* Map text column to string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@billy1624 billy1624

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error messages
2 participants
@billy1624 @tyt2y3