Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft Delete - 2 #790

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Soft Delete - 2 #790

wants to merge 19 commits into from

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Jun 9, 2022

PR Info

Adds

  • SoftDeleteTrait
  • DeriveEntityModel and DeriveColumn procedural macros with soft_delete_column proc_macro attribute
  • Override soft_delete_expr and restore_soft_delete_expr by providing a proc_macro attribute
  • find_* methods
  • delete_* methods
  • Restore delete model
  • Codegen soft_delete_column proc_macro attribute

Breaking Changes

  • DeleteOne and DeleteMany now implement QueryTrait, QueryFilter, ConditionalStatement and QueryStatementBuilder

@billy1624 billy1624 self-assigned this Jun 9, 2022
@billy1624 billy1624 requested a review from tyt2y3 June 13, 2022 10:22
@billy1624 billy1624 marked this pull request as ready for review June 14, 2022 07:55
@tyt2y3
Copy link
Member

tyt2y3 commented Jun 30, 2022

This will probably not land in 0.9

@billy1624
Copy link
Member Author

Too much for 0.9?

@billy1624 billy1624 marked this pull request as draft July 12, 2022 05:24
@billy1624 billy1624 marked this pull request as ready for review August 25, 2022 10:12
@billy1624 billy1624 marked this pull request as draft September 22, 2022 07:16
@rakshith-ravi
Copy link

Any chance this will make it through to 0.12?

@tyt2y3
Copy link
Member

tyt2y3 commented Jun 19, 2023

There is some chance, we plan to rethink/rework this PR.

But before that we'd have to clear the backlog for 0.12 first.

May be it will land in 0.12.1?

Meanwhile, any form of contribution would be appreciated.

@amorfc
Copy link

amorfc commented Jul 28, 2023

Hello, how things going on about soft-delete feature ?

@wvffle
Copy link

wvffle commented Apr 8, 2024

Hi, 0.12.15 landed a few weeks ago, is there any active work done on this PR?

@boringplay
Copy link

Hello, how things going on about soft-delete feature ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

[Feature Request] Soft Delete
6 participants