Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mul and div for SimpleExpr #510

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Add mul and div for SimpleExpr #510

merged 1 commit into from
Nov 7, 2022

Conversation

andyquinterom
Copy link
Contributor

PR Info

Simply adds the mul and div methods for SimpleExpr. Tests where added and passed!

New Features

  • Adds the mul and div methods for SimpleExpr

ikrivosheev
ikrivosheev approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyquinterom thank you! LGTM!

@ikrivosheev ikrivosheev merged commit fd50d8b into SeaQL:master Nov 7, 2022
@andyquinterom andyquinterom deleted the simple_expr_mul branch November 7, 2022 19:57
@ikrivosheev ikrivosheev mentioned this pull request Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikrivosheev ikrivosheev ikrivosheev approved these changes

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyquinterom @tyt2y3 @ikrivosheev