Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove panic from SimpleExpr and impl PgExpr and SqliteExpr traits #519

Merged
merged 5 commits into from
Nov 23, 2022
Merged

Remove panic from SimpleExpr and impl PgExpr and SqliteExpr traits #519

merged 5 commits into from
Nov 23, 2022

Conversation

ikrivosheev
Copy link
Member

@ikrivosheev ikrivosheev commented Nov 13, 2022 •
edited
Loading

PR Info

New Features

  • Introduce trait Expression
  • Introduce trait PgExpr with postgres specific method and operator
  • Introduce trait SqliteExpr with sqlite specific method and operator

Breaking Changes

  • Deprecate Expr::into_simple_expr

Changes

  • Remove panic from SimpleExpr

CC @evgeniy-terekhin

@ikrivosheev ikrivosheev self-assigned this Nov 13, 2022
billy1624
billy1624 reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! Can we also have doc test on SqliteExpr's method?

Oh, and I think the PR isn't completed yet? I don't see code for building query contains SqliteExpr.

@ikrivosheev
Copy link
Member Author

Nice work!! Can we also have doc test on SqliteExpr's method?

Oh, and I think the PR isn't completed yet? I don't see code for building query contains SqliteExpr.

Ups, I forget push it...

@ikrivosheev
Copy link
Member Author

Nice work!! Can we also have doc test on SqliteExpr's method?

Oh, and I think the PR isn't completed yet? I don't see code for building query contains SqliteExpr.

@billy1624 done.

@ikrivosheev ikrivosheev mentioned this pull request Nov 16, 2022
Merged
1 task
@ikrivosheev
Copy link
Member Author

@billy1624 @tyt2y3 can you review, please?)

@tyt2y3
Copy link
Member

tyt2y3 commented Nov 22, 2022

This is a long one and I am going over it

tyt2y3
tyt2y3 approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really liked the simplification removing lots of Expr::xxx

@tyt2y3
Copy link
Member

tyt2y3 commented Nov 23, 2022

After you merged it, can you also add some notes to the "Breaking changes" section?

Basically, some methods are moved behind traits, and thus has to be imported.

@ikrivosheev ikrivosheev merged commit 2aea543 into SeaQL:master Nov 23, 2022
@ikrivosheev ikrivosheev deleted the feature/remove_panic_from_expr branch November 23, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

@billy1624 billy1624 Awaiting requested review from billy1624

Assignees

@ikrivosheev ikrivosheev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikrivosheev @tyt2y3 @billy1624