Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issues-520] Add support postgres starts_with function #529

Merged
merged 4 commits into from
Nov 29, 2022
Merged

[issues-520] Add support postgres starts_with function #529

merged 4 commits into from
Nov 29, 2022

Conversation

ikrivosheev
Copy link
Member

PR Info

New Features

  • Added PgFunc::starts_with

@ikrivosheev ikrivosheev mentioned this pull request Nov 25, 2022
Closed
@ikrivosheev ikrivosheev self-assigned this Nov 25, 2022
billy1624
billy1624 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! @ikrivosheev LGTM

It's a surprise that Postgres don't have a ends_with function

@ikrivosheev ikrivosheev merged commit 2b08152 into SeaQL:master Nov 29, 2022
@ikrivosheev ikrivosheev deleted the feautre/issues-520_starts_with-pg_function branch November 29, 2022 08:45
@emmiegit emmiegit mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 approved these changes

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@ikrivosheev ikrivosheev

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use PostgreSQL text functions for starts_with and ends_with instead of LIKE
2 participants
@ikrivosheev @billy1624