Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extension create statement for PostgreSQL #616

Merged
merged 15 commits into from
Jul 2, 2023
Merged

feat: extension create statement for PostgreSQL #616

merged 15 commits into from
Jul 2, 2023

Conversation

LeoBorai
Copy link
Contributor

@LeoBorai LeoBorai commented Mar 7, 2023

PR Info

  • Dependencies:

New Features

  • Capability to Create an Extension on PostgreSQL

@LeoBorai LeoBorai mentioned this pull request Mar 7, 2023
Merged
1 task
@LeoBorai
Copy link
Contributor Author

LeoBorai commented Mar 7, 2023

Looks like FTM must be run with nightly right?

@billy1624
Copy link
Member

Looks like FTM must be run with nightly right?

Correct! Execute cargo +nightly fmt on your local machine. Sorry for the trouble :P

@LeoBorai LeoBorai requested a review from billy1624 March 8, 2023 17:03
@ikrivosheev
Copy link
Member

@EstebanBorai hello! Any updates?)

@LeoBorai
Copy link
Contributor Author

@EstebanBorai hello! Any updates?)

Hi @ikrivosheev!

I will continue to work on this during the week! I will be adding you as a reviewer as well!

Thanks for your time!

@ikrivosheev
Copy link
Member

@EstebanBorai great! Thank you) I'll be waiting)

@LeoBorai
Copy link
Contributor Author

LeoBorai commented Jun 4, 2023

Im fixing clippy issues on: #644

@LeoBorai LeoBorai force-pushed the feat/extension-create-statement branch from a6fb2ea to 5e1658c Compare June 4, 2023 22:15
@LeoBorai LeoBorai requested a review from billy1624 June 12, 2023 03:01
@LeoBorai LeoBorai requested a review from billy1624 June 26, 2023 17:06
billy1624
billy1624 reviewed Jun 28, 2023
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments above. All good! Thanks!! @EstebanBorai

@billy1624 billy1624 requested a review from ikrivosheev June 28, 2023 07:45
@LeoBorai LeoBorai requested a review from billy1624 June 29, 2023 23:54
billy1624
billy1624 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution as always! @EstebanBorai

@LeoBorai
Copy link
Contributor Author

LeoBorai commented Jul 1, 2023

Thanks for the contribution as always! @EstebanBorai

Thanks to you and @ikrivosheev!!

ikrivosheev
ikrivosheev approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EstebanBorai , thank you! LGTM!

@LeoBorai
Copy link
Contributor Author

LeoBorai commented Jul 2, 2023

@billy1624 , @ikrivosheev by merging this Im planning to move into #604

@ikrivosheev ikrivosheev merged commit f58193a into SeaQL:master Jul 2, 2023
@LeoBorai LeoBorai deleted the feat/extension-create-statement branch July 2, 2023 16:12
@github-actions
Copy link

🎉 Released In 0.29.0 🎉

Your participation is what makes us unique; your adoption is what drives us forward.
Thank you all in the Rust community for making SeaQL what it is today. 🦀
You are also invited to shape it's future! Please star our repos, every ⭐ counts!

@github-actions
Copy link

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikrivosheev ikrivosheev ikrivosheev approved these changes

@billy1624 billy1624 billy1624 approved these changes

Assignees

@LeoBorai LeoBorai

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeoBorai @billy1624 @ikrivosheev