Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publically export FuncArgMod #751

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

mgmarlow
Copy link
Contributor

@mgmarlow mgmarlow commented Feb 6, 2024

PR Info

Just like #get_args and #get_func, make a getter for mods, #get_mods, and make FuncArgMod public.

We're using sea-query with a non-supported database (Hive). The QueryBuilder interface set up in sea-query is nicely designed such that we can extend it for our purposes, but it has a problem in that many of the internals used by similar QueryBuilder structs (e.g. sqlite, postgres) make use of private APIs. This means that while the path is clear for creating a custom query builder, doing so without maintaining a fork requires duplicating lots of code to create public interfaces for our project.

#get_mods is one such interface that we need to write DISTINCT queries in our query builder.

New Features

  • Add FunctionCall#get_mods to get FuncArgMods

Bug Fixes

NA

Breaking Changes

NA

Changes

  • Publically export FuncArgMod struct
  • Add FunctionCall#get_mods

@choubacha
Copy link

@tyt2y3 Wonder if this could get attention? We're working off of a fork and would rather get back onto a released version. Thanks!

@tyt2y3
Copy link
Member

tyt2y3 commented Jun 27, 2024

yes sure, thanks for the nudge

@tyt2y3 tyt2y3 merged commit f27a74b into SeaQL:master Jun 27, 2024
Copy link

🎉 Released In 0.31.0-rc.9 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants