Update #1
Merged
Update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!! here, function isResetPasswordLinkTokenExpired ( app/code/core/Mage/Adminhtml/Helper/Dashboard/Data.php ) will take it and it should be first!!
someone who know 'good patterns' can tell if it should be so or it should be like :
if (!isset($userToken) || !hash_equals($userToken, $resetPasswordLinkToken) || $user->isResetPasswordLinkTokenExpired()) {
* Fix calculation of base total in magento report with discount Actually magento store discount with negative value : - 10 If you have an order with subtotal = 90 and base_discount_invoiced = -10 When Magento do base_subtotal_invoiced - base_discount_invoiced => 90 -- 10 => 90 +10 => 100 * Update fix I think it's clearer with ABS value, like magento do for the other columns
Related to configs that uses 'config_path' parameter only - payment config section for example.
+ downloaded latest release and merged into mainstream
Updated to Magento 1.9.4.2
app/design/adminhtml/default/default/template/catalog/product/helper/gallery.phtml
Upstream merge 1.9.4.2
* Drop support for EOL PHP5 * Updated .travis.yml
maintain hash_equals first argument which shouldn't be NULL.
* Forcing HTTPS
Wrong translation field fix
…he XML_USE_HTTPS_PATH const. (#800) * Forcing HTTPS * Misc revisions * Removing scheme var * Adding backwards compatibility with some 3rd party modules that use the XML_USE_HTTPS_PATH const.
Upstream merge 1.9.4.3
Added ability to respect the file delimiter in import functionality. This relates to the PRODSECBUG-2462
The current observer does a brute-force search to find a current summary related to a product in the collection. It becomes visible when you show 1000 products on a page and increases exponentially with the increased size of product collection. Fix replaces brute force search (O(n^m)) with a hash map lookup (O(n))
the signature is now calculated a bit differently to match other implementations. BREAKING CHANGE: existing OAuth applications may encounter some issues leading to `invalid_signature` 401 errors from Magento due to the removal of natural sorting for parameters when generating the signature
* Suggested fix to make $quote->getItemById more robust
Several new quote and order flows do not always trigger and set the quoteid ... the quote is then created with items but has no id yet ... and getItemById () does not work in these case because there is a different key. This happens for instance when orders are created via
/** @var Mage_Sales_Model_Service_Quote $service */
$service = Mage::getModel('sales/service_quote', $quote);
$service->submitAll();
Please review and UPDATE my code suggestion directly. Needs a proper review as it is quite in the core of quotes of M1
* Small fix
for defense, the TravisCI did not run for the PullRequest
* Fix email/admin_new_user_notification template Fix Decoding failed: Syntax error Someone missed a } in the template @vars header This should allow users to load this template in the "System -> Transactional Emails" area. * Update Mage_Core.csv added "New Admin User Email Template" label * Add system field Add admin_notification_email_template system field, so an admin can choose a transactional email when enabling System -> Configuration -> Advanced -> Admin -> Security -> New Admin User Create Notification
…lity is actually needed. (#835)
…ded by parentheses. (#836)
`Mage_Eav` has a call to `each` which is deprecated as of PHP 7.2 https://www.php.net/manual/en/function.each.php
* add PHP Starter Github Action * Update composer.json
Ref magento/zf1#23 ``` The issue is caused by the fact that the response result is checked by a regular expression that expects the Protocol version in the d.d format (for example, 1.0 or 1.1). For HTTP 2.0, the header returns a value in the format "HTTP/2 200 OK" without the decimal part. This results in an error. ```
OpenMage follows Semantic Versioning 2.0.0 Also preparation for the first 19.4.0 Release
* magento-lts-868 Add .gitignore file * Allow package folder and files in it
php 7.4 related change, as the used function get_magic_quotes_gpc() is now deprecated
`each()` is deprecated as of PHP 7.2 https://www.php.net/manual/en/function.each.php
Add created_at and updated_at to all relevant REST API resources
Sekiphp
pushed a commit
that referenced
this pull request
Feb 6, 2021
…nMage#1403) * TypeError: round(): Argument #1 ($num) must be of type int|float
Sekiphp
pushed a commit
that referenced
this pull request
Jan 21, 2024
Sekiphp
pushed a commit
that referenced
this pull request
Jan 21, 2024
…nMage#3655) * Fixed strip_tags(): Passing null to parameter #1 in Fulltext.php * Preserve PHP7.4 return value.
fballiano
pushed a commit
that referenced
this pull request
Feb 8, 2024
…duct/Option/Type/File.php (OpenMage#3775)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.