Skip to content

Conversation

diemol
Copy link
Member

@diemol diemol commented Jul 19, 2020

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This PR addresses issue #992

Browser images will be tagged like this:

# Current tagging convention, kept for backwards compatibility
selenium/standalone-chrome              4.0.0-alpha-6-20200720
# Short browser version
selenium/standalone-chrome              84.0                                  
# Short browser version and build date
selenium/standalone-chrome              84.0-20200720               
# Short browser version, short browser driver version
selenium/standalone-chrome              84.0-chromedriver-84.0 
# Short browser version, short browser driver version plus build date
selenium/standalone-chrome              84.0-chromedriver-84.0-20200720
# Verbose tag (Short browser version, short browser driver version, grid version plus build date)
selenium/standalone-chrome              84.0-chromedriver-84.0-grid-4.0.0-alpha-6-20200720                   
# Browser version
selenium/standalone-chrome              84.0.4147.89  
# Browser version and build date
selenium/standalone-chrome              84.0.4147.89-20200720
# Browser version and browser driver version
selenium/standalone-chrome              84.0.4147.89-chromedriver-84.0.4147.30
# Browser version and browser driver version plus build date
selenium/standalone-chrome              84.0.4147.89-chromedriver-84.0.4147.30-20200720
# Verbose tag (Browser version, browser driver version, grid version plus build date)
selenium/standalone-chrome              84.0.4147.89-chromedriver-84.0.4147.30-grid-4.0.0-alpha-6-20200720   

Motivation and Context

To make the docker images tags more verbose, with that, users can easily see what versions are included in each image.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol changed the title Generating date automatically Improving tags for docker images Jul 19, 2020
@diemol diemol marked this pull request as ready for review July 20, 2020 11:15
@diemol diemol merged commit 81e0712 into trunk Jul 20, 2020
@diemol diemol deleted the improve-tagging branch July 20, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant