Skip to content

Conversation

UlianaHolub
Copy link

@UlianaHolub UlianaHolub commented Jul 16, 2021

Original node config json can contain 'custom' property, but current 'generate_config' files do not support it.

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Added 'custom' property to node config.

Motivation and Context

Original node config json can contain 'custom' property, but current 'generate_config' files do not support it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Original node config json can contain 'custom' property, but current 'generate_config' files do not support it.
@CLAassistant
Copy link

CLAassistant commented Jul 16, 2021

CLA assistant check
All committers have signed the CLA.

@UlianaHolub UlianaHolub force-pushed the add-custom-property-to-node-config branch from 9d565ab to 3af9876 Compare July 19, 2021 08:53
@UlianaHolub UlianaHolub reopened this Jul 19, 2021
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, @UlianaHolub!

I need a few days to test this locally because the Travis integration does not work anymore. After that I can merge and do a release.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @UlianaHolub!
Congrats on your first contribution!

@diemol diemol merged commit 4ec6c5b into SeleniumHQ:selenium-3 Jul 29, 2021
@isaacbowen
Copy link

Not sure if this is the right place to report this, but the first release that had this PR (3.141.59-20210729) started giving us service timeouts (using selenium-webdriver). Rolling back to 3.141.59-20210713 clears those up.

@diemol
Copy link
Member

diemol commented Jul 31, 2021

This commit is not related to the issue, it is a problem in Chrome 92.

There is an issue pinned on the issues tab, please have a look, a workaround is mentioned there.

@isaacbowen
Copy link

Thanks @diemol! :) Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants