Skip to content

Conversation

selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Oct 3, 2025

User description

This PR contains the CHANGELOG for Node/Standalone with backward browser versions


PR Type

Other


Description

  • Update browser version support to include version 140

  • Update build date from 20250828 to 20250909

  • Add new Edge 139 changelog documentation

  • Update Firefox version to 143.0.3


Diagram Walkthrough

flowchart LR
  A["Build Date"] -- "20250828 → 20250909" --> B["Updated Changelogs"]
  C["Browser Versions"] -- "Add 140" --> D["Workflow Configs"]
  E["Edge 139"] -- "New Version" --> F["New Changelog"]
  G["Firefox"] -- "143.0.1 → 143.0.3" --> H["Version Matrix"]
Loading

File Walkthrough

Relevant files
Configuration changes
2 files
release-chrome-versions.yml
Add Chrome version 140 support                                                     
+1/-1     
release-edge-versions.yml
Add Edge version 140 support                                                         
+1/-1     
Documentation
19 files
edge_114.md
Update build date to 20250909                                                       
+15/-15 
edge_115.md
Update build date to 20250909                                                       
+15/-15 
edge_116.md
Update build date to 20250909                                                       
+15/-15 
edge_117.md
Update build date to 20250909                                                       
+15/-15 
edge_118.md
Update build date to 20250909                                                       
+15/-15 
edge_119.md
Update build date to 20250909                                                       
+15/-15 
edge_120.md
Update build date to 20250909                                                       
+15/-15 
edge_121.md
Update build date to 20250909                                                       
+15/-15 
edge_122.md
Update build date to 20250909                                                       
+15/-15 
edge_123.md
Update build date to 20250909                                                       
+15/-15 
edge_124.md
Update build date to 20250909                                                       
+15/-15 
edge_125.md
Update build date to 20250909                                                       
+15/-15 
edge_126.md
Update build date to 20250909                                                       
+15/-15 
edge_127.md
Update build date to 20250909                                                       
+15/-15 
edge_128.md
Update build date to 20250909                                                       
+15/-15 
edge_129.md
Update build date to 20250909                                                       
+15/-15 
edge_130.md
Update build date to 20250909                                                       
+15/-15 
edge_131.md
Update build date to 20250909                                                       
+15/-15 
edge_132.md
Update build date to 20250909                                                       
+15/-15 
Additional files
9 files
edge_133.md +15/-15 
edge_134.md +15/-15 
edge_135.md +15/-15 
edge_136.md +15/-15 
edge_137.md +15/-15 
edge_138.md +15/-15 
edge_139.md +21/-0   
browser-matrix.yml +3/-3     
firefox-matrix.yml +1/-1     

Copy link
Contributor

qodo-merge-pro bot commented Oct 3, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Copy link
Contributor

qodo-merge-pro bot commented Oct 3, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
High-level
Automate changelog generation to avoid manual updates

Automate the generation of changelog files using a templating system within the
release pipeline. This will prevent the need for manual, error-prone updates
across numerous files for simple changes like a build date.

Examples:

CHANGELOG/4.35.0/edge_114.md [1-21]

./tag_and_push_browser_images.sh 4.35.0 20250909 selenium false edge true
Tagging images for browser edge, version 4.35.0, build date 20250909, namespace selenium
Selenium Grid version -> 4.35.0-20250909
Edge version -> 114.0.1823.82
Short Edge version -> 114.0
EdgeDriver version -> 114.0.1823.82
Short EdgeDriver version -> 114.0
Tagged selenium/node-edge:114.0.1823.82-edgedriver-114.0.1823.82-grid-4.35.0-20250909
Tagged selenium/standalone-edge:114.0.1823.82-edgedriver-114.0.1823.82-grid-4.35.0-20250909

... (clipped 11 lines)

</details>



<details>
<summary>
<a href="https://github.com/SeleniumHQ/docker-selenium/pull/2974/files#diff-c942a70ee92d7b598f0693dbb1decd26fd21221b9ffc7a40dbbeb551dc894b12R1-R21">CHANGELOG/4.35.0/edge_138.md [1-21]</a>
</summary>



```markdown

./tag_and_push_browser_images.sh 4.35.0 20250909 selenium false edge true
Tagging images for browser edge, version 4.35.0, build date 20250909, namespace selenium
Selenium Grid version -> 4.35.0-20250909
Edge version -> 138.0.3351.121
Short Edge version -> 138.0
EdgeDriver version -> 138.0.3351.121
Short EdgeDriver version -> 138.0
Tagged selenium/node-edge:138.0.3351.121-edgedriver-138.0.3351.121-grid-4.35.0-20250909
Tagged selenium/standalone-edge:138.0.3351.121-edgedriver-138.0.3351.121-grid-4.35.0-20250909

... (clipped 11 lines)

</details>




### Solution Walkthrough:



#### Before:
```markdown
// In CHANGELOG/4.35.0/edge_114.md
./tag_and_push_browser_images.sh 4.35.0 20250909 ...
Selenium Grid version -> 4.35.0-20250909
...
Tagged selenium/node-edge:114.0...-20250909
Tagged selenium/standalone-edge:114.0...-20250909

// In CHANGELOG/4.35.0/edge_115.md
./tag_and_push_browser_images.sh 4.35.0 20250909 ...
Selenium Grid version -> 4.35.0-20250909
...
Tagged selenium/node-edge:115.0...-20250909
Tagged selenium/standalone-edge:115.0...-20250909

// This pattern is repeated manually for many other files.

After:

// 1. Define a template, e.g., changelog_template.md
./tag_and_push_browser_images.sh {{ grid_version }} {{ build_date }} ...
Selenium Grid version -> {{ grid_version }}-{{ build_date }}
Edge version -> {{ edge_version }}
...
Tagged selenium/node-edge:{{ edge_version }}...-{{ build_date }}
Tagged selenium/standalone-edge:{{ edge_version }}...-{{ build_date }}

// 2. Use a script in the release pipeline
function generate_changelog(version, date) {
  // read template
  // replace placeholders with version and date
  // write to CHANGELOG/.../edge_{{version}}.md
}

// The generated files are not committed to the repository.
Suggestion importance[1-10]: 8

__

Why: The suggestion correctly identifies a significant process inefficiency, as the PR manually updates a build date across dozens of files, and proposes a valuable automation strategy that would improve maintainability and reduce errors.

Medium
Learned
best practice
Quote YAML scalars with symbols

Quote scalar values containing '=' or ',' to ensure they are parsed as strings
and preserve exact content.

tests/build-backward-compatible/browser-matrix.yml [10-11]

-EDGE_VERSION: microsoft-edge-stable=141.0.3537.57-1
-CHROME_VERSION: google-chrome-stable=141.0.7390.54-1
-FIREFOX_PLATFORMS: linux/amd64,linux/arm64
+EDGE_VERSION: "microsoft-edge-stable=141.0.3537.57-1"
+CHROME_VERSION: "google-chrome-stable=141.0.7390.54-1"
+FIREFOX_PLATFORMS: "linux/amd64,linux/arm64"

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 6

__

Why:
Relevant best practice - Harden YAML by quoting values that include special characters (e.g., '=' and ',') to prevent parsing ambiguities.

Low
  • More

@VietND96 VietND96 merged commit a1edfce into trunk Oct 3, 2025
1 check passed
@VietND96 VietND96 deleted the browser-node-changelog branch October 3, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants