Change FIREFOX_VERSION from ENV to ARG + apt cache clean #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F2X
changed the title
|
thanks for this! i did notice i forgot to put that in for firefox. i'll merge it in shortly |
|
out of curiosity, have you signed the CLA? |
|
Yes, I've just done it right now |
ddavison
added
I-firefox-all
and removed
I-firefox
I-firefox-debug
I-standalone-firefox
I-standalone-firefox-debug
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As FIREFOX_VERSION seems to be used only at build, it should be an ARG to not be confused with env variables. This modification was done for chrome image but not for firefox one.