added ENV variable VNC_NO_PASSWORD to disable password auth #708
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this change, if I can simply VNC into the running container without having to type in the password. |
|
Hi @schmunk42, Thanks for the PR! We'll do a review during the weekend to merge and then release. |
|
Any updates on this @diemol ? |
|
LGTM! 👍 |
|
Thank you @ddavison ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #701
Just supplying an empty password does not work, therefore I added a check which sets the proper command param.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement