Skip to content

Conversation

testphreak
Copy link
Contributor

@testphreak
Copy link
Contributor Author

Adding a minor change, so whenever a new image is created with a new version of Selenium, whatever the latest stable Firefox is at that time, gets downloaded by default as part of the build, just as we do today with Chrome. Hopefully if this change is accepted, we will not need new pull requests for new versions of stable Firefox.

@testphreak
Copy link
Contributor Author

@diemol, @ddavison can we get this merged?

@diemol
Copy link
Member

diemol commented Mar 27, 2018

Hi @testphreak,

Thanks for the PR! We'll do a review during the weekend to merge and then release with the new FF version 59.0.2

@testphreak
Copy link
Contributor Author

Thanks @diemol. I made a minor change to not add an else if condition to an already long line. The downside to that is folks who were previously specifying just devedition or nightly, now need to add devedition-latest or nightly-latest.

@diemol
Copy link
Member

diemol commented Apr 2, 2018

Just tested it and it works! Thanks @testphreak

@diemol diemol merged commit b244466 into SeleniumHQ:master Apr 2, 2018
@ddavison
Copy link
Member

ddavison commented Apr 3, 2018

we already do this for Chrome, so makes sense we have this for FF. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants