-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Support for Selenium nodes with Opera browser #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @ehbello!
I left a couple of suggestions, and also a comment because the standalone images are not being generated.
b1ad0e2
to
786d5fb
Compare
786d5fb
to
3c67e57
Compare
I removed all automatically generated files (Dockerfile, README.md, etc) at release. |
Hi @ehbello, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @ehbello, thank you!
As mentioned before:
- We will merge this but we'll only have the first Opera images with the Selenium Grid 4 Alpha
- We will also monitor how much people use this image vs. how much maintenance demands.
FWIW, the other directories all include them in git.
|
@cben These files will be generated at release. Wait for it 😉 |
Description
This pull request provides the following changes:
Motivation and Context
These changes will allow us to use Opera as a new browser to test with Selenium.
We, at System73, have been using Selenium to test our software for several years. We needed to implement these changes for Selenium nodes to work with Opera and now we are sharing them with the community.
Types of changes
Checklist