Skip to content

Conversation

ehbello
Copy link
Contributor

@ehbello ehbello commented Dec 30, 2019

Description

This pull request provides the following changes:

  1. Add the necessary files to build all types of Selenium nodes with the Opera browser.
  2. Enable existing tests for the resulting Docker Images
  3. Update the README.md file to describe the usage of the

Motivation and Context

These changes will allow us to use Opera as a new browser to test with Selenium.

We, at System73, have been using Selenium to test our software for several years. We needed to implement these changes for Selenium nodes to work with Opera and now we are sharing them with the community.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@claassistantio
Copy link

claassistantio commented Dec 30, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @ehbello!
I left a couple of suggestions, and also a comment because the standalone images are not being generated.

@ehbello ehbello force-pushed the opera-support branch 2 times, most recently from b1ad0e2 to 786d5fb Compare February 18, 2020 15:53
@ehbello
Copy link
Contributor Author

ehbello commented Feb 20, 2020

I removed all automatically generated files (Dockerfile, README.md, etc) at release.

@maximehyh
Copy link

Hi @ehbello,
Thanks for all the work on the FF video support and Opera browser.
Since it is now Chromium based I was wondering if you or @diemol had some ambition to make the same with Edge (https://www.microsoftedgeinsider.com/fr-fr/download)?
Thx!
Maxime

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @ehbello, thank you!
As mentioned before:

  • We will merge this but we'll only have the first Opera images with the Selenium Grid 4 Alpha
  • We will also monitor how much people use this image vs. how much maintenance demands.

@diemol diemol merged commit 2365193 into SeleniumHQ:master Mar 2, 2020
@ehbello ehbello deleted the opera-support branch March 2, 2020 15:46
@cben
Copy link

cben commented Mar 14, 2020

I removed all automatically generated files (Dockerfile, README.md, etc) at release.

FWIW, the other directories all include them in git.

@ehbello
Copy link
Contributor Author

ehbello commented Mar 15, 2020

@cben These files will be generated at release. Wait for it 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants