[py] added pythonic approach of type checking in firefox/firefox_profile.py
#12271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
In
accept_untrusted_certs
andassume_untrusted_cert_issuer
setter methods, we are checking if thevalue
is eitherTrue
orFalse
using membership operator, likevalue in [True, False]
, which is not a standard way of python type checking. I have changed it to use python's built-inisinstance
.Motivation and Context
Motivation for this change is to make type checking more pythonic.
Types of changes
Checklist