Skip to content

Conversation

sandeepsuryaprasad
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

In accept_untrusted_certs and assume_untrusted_cert_issuer setter methods, we are checking if the value is either True or False using membership operator, like value in [True, False], which is not a standard way of python type checking. I have changed it to use python's built-in isinstance.

Motivation and Context

Motivation for this change is to make type checking more pythonic.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (1fe0628) 57.22% compared to head (1dab78e) 57.22%.

❗ Current head 1dab78e differs from pull request most recent head 99434a5. Consider uploading reports for the commit 99434a5 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12271   +/-   ##
=======================================
  Coverage   57.22%   57.22%           
=======================================
  Files          86       86           
  Lines        5480     5480           
  Branches      226      226           
=======================================
  Hits         3136     3136           
  Misses       2118     2118           
  Partials      226      226           
Impacted Files Coverage Δ
py/selenium/webdriver/firefox/firefox_profile.py 18.84% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AutomatedTester AutomatedTester merged commit 1ea0f18 into SeleniumHQ:trunk Jun 28, 2023
@sandeepsuryaprasad sandeepsuryaprasad deleted the firefox_options branch November 24, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants