Skip to content

[py] added pythonic approach of type checking in firefox/firefox_profile.py #12271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[py] added pythonic approach of type checking in firefox/firefox_profile.py #12271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions py/selenium/webdriver/firefox/firefox_profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def accept_untrusted_certs(self):

@accept_untrusted_certs.setter
def accept_untrusted_certs(self, value) -> None:
if value not in [True, False]:
if not isinstance(value, bool):
raise WebDriverException("Please pass in a Boolean to this call")
self.set_preference("webdriver_accept_untrusted_certs", value)

Expand All @@ -140,7 +140,7 @@ def assume_untrusted_cert_issuer(self):

@assume_untrusted_cert_issuer.setter
def assume_untrusted_cert_issuer(self, value) -> None:
if value not in [True, False]:
if not isinstance(value, bool):
raise WebDriverException("Please pass in a Boolean to this call")

self.set_preference("webdriver_assume_untrusted_issuer", value)
Expand Down