Update by.js: Add forgotten RelativeBy in check options #12289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change expands a check for type By tp type RelativeBy to have later work, too.
Motivation and Context
I assume at some time RelativeBy was introduced. Several code places have been adjusted to accomodate the new type.
The changed line was forgotten und broke the function until.elementLocated() (and probably others) when used in connection with locateWith().
The function elementLocated() calls - like other functions, too - By.checkedLocator() which unnecessarily throws an error for parameters of type RelativeBy as produced by locateWith(). The function calls after the check have already been adjusted to work with RelativeBy.
Types of changes
Checklist