Skip to content

Update by.js: Add forgotten RelativeBy in check options #12289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2023
Merged

Update by.js: Add forgotten RelativeBy in check options #12289

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91ce3b5
Update by.js: Add forgotten RelativeBy in check options
AdamPDotty Jun 29, 2023
54d40b4
Merge branch 'trunk' into js_relativeby_with_until
AdamPDotty Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion javascript/node/selenium-webdriver/lib/by.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ class RelativeBy {
* strategy.
*/
function check(locator) {
if (locator instanceof By || typeof locator === 'function') {
if (locator instanceof By || locator instanceof RelativeBy || typeof locator === 'function') {
return locator
}

Expand Down