Skip to content

Conversation

nvborisenko
Copy link
Member

Description

All messages came from DevTools protocol are supposed to be processed. We are doing it in background thread one by one. If we could not process some message in queue by any reason, then the entire processing thread (actually Task) stops, which leads to another problem like page cannot be loaded.

It's is not ideal fix. But at least it gives more chances for web site to be loaded correctly while selenium is listening browser network via CDP.

Motivation and Context

Try to make DevTools more robust.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner titusfortner merged commit 313ac20 into SeleniumHQ:trunk Sep 26, 2023
@nvborisenko nvborisenko deleted the dotnet-devtools-procesing-messages branch September 26, 2023 07:18
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
…xpected exception (SeleniumHQ#12820)

Don't break devtools processing events thread in case of unexpected exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants